Encoder: properly set frame pts values #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
changed the title
NicolasHug
commented
Jul 3, 2025
| if method == "to_file": | ||
| validate_frames_properties(actual=encoded_by_us, expected=encoded_by_ffmpeg) | ||
| else: | ||
| assert method == "to_tensor", "wrong test parametrization!" |
There was a problem hiding this comment.
Interestingly enough, the call to validate_frames_properties() was passing on main. That's because the underlying encoder was able to infer pts valid values. But it was emitting warnings that were visible in DEBUG mode.
The other tests we have above (assert ... not in captured.err) make sure those warnings aren't emitted anymore, confirming we are now correctly setting the pts values explicitly.
scotts
approved these changes
Jul 3, 2025
Dan-Flores
pushed a commit
to Dan-Flores/torchcodec
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure we properly set the AVFrames's pts values before sending them to the encoder.
This removes a bunch of warnings that were visible when using
TORCHCODEC_FFMPEG_LOG_LEVEL=DEBUG. I added tests to make sure these warnings have now disappeared. I also confirmed that the tests fail onmainwithout the fixes.