Skip to content

Fix the assignment logic of the variable "self.num_batches" in RandomRecDataset #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Fix the assignment logic of the variable "self.num_batches" in RandomRecDataset #3364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef09ec4
fix: fix num_batches
hegongshan Sep 9, 2025
dccd743
style: format code
Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion torchrec/datasets/random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,9 @@ def __init__(
num_generated_batches=num_generated_batches,
min_ids_per_features=min_ids_per_features,
)
self.num_batches: int = cast(int, num_batches if not None else sys.maxsize)
self.num_batches: int = cast(
int, num_batches if num_batches is not None else sys.maxsize
)

def __iter__(self) -> Iterator[Batch]:
return itertools.islice(iter(self.batch_generator), self.num_batches)
Expand Down