-
Notifications
You must be signed in to change notification settings - Fork 503
Adding StateDictAdapter #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding StateDictAdapter #1601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: Please fix __init__.py
first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost forgot to mention, you need to plug in the stateDictAdapter in __init__.py
Fixed |
@HosseinKaviani-H has imported this pull request. If you are a Meta employee, you can view this in D80660953. |
@HosseinKaviani-H has imported this pull request. If you are a Meta employee, you can view this in D80660953. |
@HosseinKaviani-H has imported this pull request. If you are a Meta employee, you can view this in D80660953. |
@HosseinKaviani-H has imported this pull request. If you are a Meta employee, you can view this in D80660953. |
Can you check again what's going on with this PR? Do you export the latest version of the diff? |
@HosseinKaviani-H has imported this pull request. If you are a Meta employee, you can view this in D80660953. |
I did and imported to the base again. I don't know why it's throwing an error like this. |
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
Please check the internal diff message. |
I haven't meet this error before, and please check the fix the signal |
In this PR, I'm adding the StateDictAdapter for Qwen3 to enable loading HF checkpoints. We can use this script to adapt the checkpoint from HF to the format that we can load into the torchtitan model and vice versa. This can enable us to do a parity test with the HF implementation and make sure that our results are aligned with the HF implementation. --------- Co-authored-by: Hossein Kavianihamedani <[email protected]>
In this PR, I'm adding the StateDictAdapter for Qwen3 to enable loading HF checkpoints. We can use this script to adapt the checkpoint from HF to the format that we can load into the torchtitan model and vice versa. This can enable us to do a parity test with the HF implementation and make sure that our results are aligned with the HF implementation.