Skip to content

 Fix: Align forward and backward arguments in cpp_extension tutorial #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZhigaoyuanWang
Copy link

This PR fixes a bug in the lltm_cuda_kernel.cu example by aligning the return values of the lltm_cuda_backward function with the Python backward interface.

In cpp_extension.rst line 1150:

return {d_old_h, d_input, d_weights, d_bias, d_old_cell, d_gates};

the original lltm_cuda_backward function returned six values.

However, the corresponding Python backward interface(line 470) only expects five values to be returned, as it corresponds to the number of input tensors to the forward function:

d_old_h, d_input, d_weights, d_bias, d_old_cell = outputs

This mismatch causes the example to fail at runtime.

This change corrects the lltm_cuda_backward function to return only the five required gradient tensors, bringing it into alignment with the Python side. The d_gates tensor is no longer returned, as its gradient is not needed by the caller.

Before this change: The example code would throw ValueError: too many values to unpack (expected 5).

After this change: The example will run successfully, providing a correct and functional demonstration of a custom CUDA extension.

Copy link

pytorch-bot bot commented Aug 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3520

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cea931e with merge base 3b23c0e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

meta-cla bot commented Aug 14, 2025

Hi @ZhigaoyuanWang!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

meta-cla bot commented Aug 14, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant