Skip to content

Prepare for pytorch tensor impl change in is_contiguous_custom #9402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Prepare for pytorch tensor impl change in is_contiguous_custom #9402

merged 1 commit into from
Jun 25, 2025

Conversation

laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Jun 23, 2025 •
edited
Loading

in this PR pytorch/pytorch#155590 we do the following changes to the tesnor impl API

  1. bool is_contiguous_custom does not need to overriden by other classes anymore
  2. we add SymBool sym_is_contiguous_custom.

I am trying to avoid breaking pytorch test, want to land this, then land pytorch/pytorch#155590, then come back here and clean up this .

@laithsakka laithsakka marked this pull request as draft June 23, 2025 22:23
@laithsakka laithsakka force-pushed the hh branch 2 times, most recently from 4dc049e to 1574927 Compare June 23, 2025 22:53
@laithsakka laithsakka marked this pull request as ready for review June 23, 2025 22:53
@laithsakka
Copy link
Contributor Author

laithsakka commented Jun 23, 2025 •
edited
Loading

cc @miladm @ezyang

@laithsakka laithsakka changed the title prepare for pytorch tensor impl change in is_contiguous_custom Prepare for pytorch tensor impl change in is_contiguous_custom Jun 23, 2025
@laithsakka
Copy link
Contributor Author

laithsakka commented Jun 24, 2025 •
edited
Loading 

Error when evaluating 'secrets'. .github/workflows/build_and_test.yml (Line: 81, Col: 11): Secret TORCH_XLA_BOT_TOKEN is required, but not provided while calling., .github/workflows/build_and_test.yml (Line: 81, Col: 11): Secret GCLOUD_SERVICE_KEY is required, but not provided while calling.Show more

@qihqi do you know what is this error?

@laithsakka
Copy link
Contributor Author

rebase

@laithsakka
Copy link
Contributor Author

ok this seems to be a effecting many other PRs not related i think we can land this.

@ezyang ezyang merged commit 926700d into pytorch:master Jun 25, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laithsakka @ezyang