EmbeddingDenseBackward: Remove padding_idx cast to double
#9406
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unterumarmung
force-pushed
the
embedding-cast-remove
branch
from
b3025d5 to
6f68495
Compare
unterumarmung
changed the title
padding_idx double castpadding_idx cast to double
|
Thanks for the change! I am going to run the CI and see if it breaks anything |
|
Can you also please add a test for embedding backward similar to this one Line 738 in 193f704 |
|
Done. Please, rerun the CI |
unterumarmung
changed the title
padding_idx cast to doubleEmbeddingDenseBackward: Remove padding_idx cast to double
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9392