Skip to content

Style improvements. #9410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Style improvements. #9410

merged 1 commit into from
Jun 26, 2025

Conversation

zhanyong-wan
Copy link
Collaborator

@zhanyong-wan zhanyong-wan commented Jun 25, 2025

  • Define string literal constants as inline constexpr char[] - it's more concise, and allows the constants to be used in more contexts.
  • Simplify some implementation.
  • Fix some #includes.
  • Make GetComputationClient() return a const & to avoid making a copy every time.
  • Use const in more places.

@zhanyong-wan zhanyong-wan requested a review from ysiraichi June 25, 2025 23:25
@zhanyong-wan zhanyong-wan enabled auto-merge (squash) June 25, 2025 23:25
@zhanyong-wan zhanyong-wan requested a review from ghpvnist June 26, 2025 15:58
@zhanyong-wan zhanyong-wan merged commit 37c8eb1 into pytorch:master Jun 26, 2025
23 of 24 checks passed
@zhanyong-wan zhanyong-wan deleted the style branch June 26, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants