Skip to content

Fix spmd sharding visualization when device index is >= 10 #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Fix spmd sharding visualization when device index is >= 10 #9475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions torch_xla/distributed/spmd/debugging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,24 +57,26 @@ def visualize_sharding(sharding: str,
# eg: '{devices=[2,2]0,1,2,3}'
# eg: '{replicated}'
# eg: '{devices=[2,1,2]0,1,2,3 last_tile_dim_replicate}'
print(f"Visualizing {sharding} (showing up to the first two dimensions)")
if sharding == '{replicated}' or len(sharding) == 0:
heights = 1
widths = 1
num_devices = xr.global_runtime_device_count()
device_ids = list(range(num_devices))
slices.setdefault((0, 0), device_ids)
else:
sharding_spac = sharding[sharding.index('['):sharding.index(']') + 1]
sharding_spec = sharding[sharding.index('[') +
1:sharding.index(']')].split(",")
device_list_original = sharding.split(' last_tile_dim_replicate')
if len(device_list_original) == 2 and device_list_original[1] == '}':
try:
device_list_original_first = device_list_original[0]
device_list = device_list_original_first[device_list_original_first.
index(']') + 1:]
device_indices_map = [int(s) for s in device_list.split(',')]
heights = int(sharding_spac[1])
widths = int(sharding_spac[3])
last_dim_depth = int(sharding_spac[5])
heights = int(sharding_spec[0])
widths = int(sharding_spec[1])
last_dim_depth = int(sharding_spec[-1])
devices_len = len(device_indices_map)
len_after_dim_down = devices_len // last_dim_depth
for i in range(len_after_dim_down):
Expand All @@ -96,8 +98,8 @@ def visualize_sharding(sharding: str,
device_list = device_list_original_first[device_list_original_first.
index(']') + 1:-1]
device_indices_map = [int(i) for i in device_list.split(',')]
heights = int(sharding_spac[1])
widths = int(sharding_spac[3])
heights = int(sharding_spec[0])
widths = int(sharding_spec[1])
devices_len = len(device_indices_map)
for i in range(devices_len):
slices.setdefault((i // widths, i % widths), device_indices_map[i])
Expand Down
Loading