fix harness #500
Open
fix harness #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using main en.lua was translated to Ukrainian language.
using main en.lua was translated to Ukrainian language. I have personally loaded this code into an updated qbcore project and checked all it's functionality This code fit the style guidelines This PR fit the contribution guidelines
Description of Changes Added full validation to the equip:harness server event to prevent runtime errors caused by missing or undefined item slot data. Introduced local variables for safer access to nested fields such as Player.PlayerData.items[slot].info.uses. Applied default value (Config.HarnessUses - 1) when uses data is not present, ensuring stability and continuity of harness logic. Prevented the script from crashing with attempt to index a nil value by checking all required fields before accessing them. Testing Changes were tested in-game in multiple scenarios: Harness item with no info.uses field: correctly initializes the value and does not crash. Harness item with uses = 1: removes the item as expected. Harness item with uses > 1: decreases the use count and updates inventory properly. No errors or crashes occurred during testing.
fixed error when use harness
Z3rio
suggested changes
Aug 1, 2025
Comment on lines
+1
to
+67
| local Translations = { | ||
| afk = { | ||
| will_kick = "Ви AFK і будете кікнуті через ", | ||
| time_seconds = " секунд!", | ||
| time_minutes = " хвилину(и)!", | ||
| kick_message = "Вас було кікнуто за бездіяльність (AFK)" | ||
| }, | ||
| wash = { | ||
| in_progress = "Авто миється...", | ||
| wash_vehicle = "[E] Помити авто", | ||
| wash_vehicle_target = "Помити авто", | ||
| dirty = "Авто не забруднене", | ||
| cancel = "Миття скасовано..." | ||
| }, | ||
| consumables = { | ||
| eat_progress = "Їсте...", | ||
| drink_progress = "П'єте...", | ||
| liqour_progress = "Вживаєте алкоголь...", | ||
| coke_progress = "Швидке вдихання...", | ||
| crack_progress = "Курите крек...", | ||
| ecstasy_progress = "Ковтаєте пігулки...", | ||
| healing_progress = "Зцілення...", | ||
| meth_progress = "Курите жорсткий мет...", | ||
| joint_progress = "Підпалюєте косяк...", | ||
| use_parachute_progress = "Надягаєте парашут...", | ||
| pack_parachute_progress = "Пакуєте парашут...", | ||
| no_parachute = "У вас немає парашута!", | ||
| armor_full = "У вас вже достатньо броні!", | ||
| armor_empty = "На вас немає бронежилета...", | ||
| armor_progress = "Надягаєте бронежилет...", | ||
| heavy_armor_progress = "Надягаєте важкий бронежилет...", | ||
| remove_armor_progress = "Знімаєте бронежилет...", | ||
| canceled = "Скасовано..." | ||
| }, | ||
| cruise = { | ||
| unavailable = "Круїз-контроль недоступний", | ||
| activated = "Круїз-контроль активовано", | ||
| deactivated = "Круїз-контроль вимкнено" | ||
| }, | ||
| editor = { | ||
| started = "Запис розпочато!", | ||
| save = "Запис збережено!", | ||
| delete = "Запис видалено!", | ||
| editor = "До зустрічі, алігаторе!" | ||
| }, | ||
| firework = { | ||
| place_progress = "Встановлення феєрверку...", | ||
| canceled = "Скасовано...", | ||
| time_left = "Запуск феєрверку через ~r~" | ||
| }, | ||
| seatbelt = { | ||
| use_harness_progress = "Пристібання гоночного ременя", | ||
| remove_harness_progress = "Зняття гоночного ременя", | ||
| no_car = "Ви не в автомобілі." | ||
| }, | ||
| teleport = { | ||
| teleport_default = "Скористатись ліфтом" | ||
| }, | ||
| pushcar = { | ||
| stop_push = "[E] Зупинити штовхання" | ||
| } | ||
| } | ||
|
|
||
| Lang = Lang or Locale:new({ | ||
| phrases = Translations, | ||
| warnOnMissing = true | ||
| }) |
There was a problem hiding this comment.
Put this in a different PR, this is not what this PR aims to do (supposedly)?
And fix the issues with it ofcourse, as it currently lacks the .lua extension.
| Player.Functions.SetInventory(Player.PlayerData.items) | ||
| elseif Player.PlayerData.items[item.slot].info.uses == 1 then | ||
| elseif uses == 1 then | ||
| exports['qb-inventory']:RemoveItem(src, 'harness', 1, false, 'equip:harness') |
There was a problem hiding this comment.
Suggested change
| exports['qb-inventory']:RemoveItem(src, 'harness', 1, false, 'equip:harness') | |
| exports['qb-inventory']:RemoveItem(src, 'harness', 1, slot, 'equip:harness') |
We need to define the slot here, so another harness with full usage doesnt get removed forexample.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added full validation to the equip:harness server event to prevent runtime errors caused by missing or undefined item slot data. Introduced local variables for safer access to nested fields such as Player.PlayerData.items[slot].info.uses. Applied default value (Config.HarnessUses - 1) when uses data is not present, ensuring stability and continuity of harness logic. Prevented the script from crashing with attempt to index a nil value by checking all required fields before accessing them.
Testing
Changes were tested in-game in multiple scenarios: Harness item with no info.uses field: correctly initializes the value and does not crash. Harness item with uses = 1: removes the item as expected. Harness item with uses > 1: decreases the use count and updates inventory properly. No errors or crashes occurred during testing.