Addition of the D60B tsangan pcb #25245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
May 7, 2025
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
waffle87
requested changes
May 7, 2025
waffle87
approved these changes
May 9, 2025
drashna
requested changes
May 11, 2025
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
|
Is there anything remaining that I missed preventing the PR to be approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the addition of a no-longer-available PCB sold by KBDfans around 2021. At the time, it was also referred to as the sun60, but the name on the PCB is D60 B.
It is a hot-swap PCB with per-key RGB and no backlight. When I purchased it at the end of 2021, KBDfans kindly gave me the source firmware, which I upgraded to the new data-driven keyboard configuration.
Despite my efforts, I couldn't find a picture of the PCB to include in the README.md file.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist