feat(useNavigate): improve useNavigate to check if route exists in ember #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonardoRick
force-pushed
the
feat-react-routing-single-navigation-method
branch
3 times, most recently
from
e6ec9f8 to
efbcd55
Compare
LeonardoRick
force-pushed
the
feat-react-routing-single-navigation-method
branch
from
efbcd55 to
5952af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the useNavigate polymorphic hook to enable the usage of a single navigation method for both:
This way we can always import
useNavigateasWhenever we want to navigate in a react codebase that coexist with an Ember application.
IMPORTANT NOTE: For the method to work properly, the application should have the exact same react-router version that is being used in the repo (At the moment of this PR -
"react-router": "7.6.3")