Skip to content

Derive _kraus_ from _apply_channel_ #7434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Derive _kraus_ from _apply_channel_ #7434

wants to merge 31 commits into from
+108 −0

Conversation

iamsusiep
Copy link
Contributor

@iamsusiep iamsusiep commented Jun 24, 2025 •
edited by daxfohl
Loading

Resolves #5921
TESTED=Ran following tests for files affected.

check/pytest-changed-files
check/pytest
check/format-incremental --apply
check/pylint-changed-files
check/pytest-and-incremental-coverage

@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (fec106c) to head (c8885c2).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7434      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files        1092     1092              
  Lines       96560    96615      +55     
==========================================
+ Hits        95291    95345      +54     
- Misses       1269     1270       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamsusiep iamsusiep marked this pull request as ready for review June 24, 2025 16:00
@iamsusiep iamsusiep requested review from vtomole and a team as code owners June 24, 2025 16:00
@iamsusiep iamsusiep requested a review from senecameeks June 24, 2025 16:00
@iamsusiep
Copy link
Contributor Author

cc: @daxfohl

daxfohl
daxfohl reviewed Jun 24, 2025
View reviewed changes
daxfohl
daxfohl reviewed Jun 24, 2025
View reviewed changes
daxfohl
daxfohl approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@daxfohl daxfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@iamsusiep
Copy link
Contributor Author

iamsusiep commented Jun 26, 2025 •
edited
Loading

@pavoljuhas @vtomole @senecameeks PTAL, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxfohl daxfohl daxfohl approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@senecameeks senecameeks Awaiting requested review from senecameeks senecameeks is a code owner automatically assigned from quantumlib/cirq-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derive _kraus_ from _apply_channel_
2 participants
@iamsusiep @daxfohl