Skip to content

Fixing MS gate inverse is not implemented correctly (Issue 7432) #7466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

radumarg
Copy link
Contributor

@radumarg radumarg commented Jul 2, 2025

Fixing MS gate inverse is not implemented correctly (Issue #7432)

The MS gate has a theta entanglement angle parameter in it's signature, with a 0.25 default value. The problems that need to be corrected here is that when implementing the inverse MS gate the theta parameter is not applied, and instead implicitly its default value is being used when specifying inverse of MS in terms of MS.

Code and tests were updated.

@radumarg radumarg requested review from dabacon, vtomole and a team as code owners July 2, 2025 12:10
@github-actions github-actions bot added the Size: XS <10 lines changed label Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (e34da07) to head (3091e5e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7466   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files        1092     1092           
  Lines       96546    96546           
=======================================
+ Hits        95272    95275    +3     
+ Misses       1274     1271    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radumarg
Copy link
Contributor Author

radumarg commented Jul 2, 2025

There is one failing test but this is not related to changes in this PR.

@mhucka
Copy link
Contributor

mhucka commented Jul 2, 2025

There is one failing test but this is not related to changes in this PR.

Seems to have been a glitch. I reran the failing test and it succeeded.

@mhucka
Copy link
Contributor

mhucka commented Jul 2, 2025

@radumarg Thank you for your work! I'd like to offer some quick feedback for best practices involving pull requests:

  • Could you make the title more descriptive? It would help future readers and the release notes if the title could be something along the lines of, for example, "Fix # 7432: info info info" where the info info info briefly describes the problem this fixes. (Yes, people can read the issue, but it saves time for people scanning long lists of PRs.)

  • In the description of the issue, instead of "Fixing issue # 7432", it would be helpful to provide a summary of how the PR fixes the issue. Just the key points, like what was the core of the problem and what approach you took (and why).

@radumarg radumarg changed the title Fixing issue 7432 Fixing MS gate inverse is not implemented correctly (Issue 7432) Jul 3, 2025
@radumarg
Copy link
Contributor Author

radumarg commented Jul 3, 2025

@mhucka this PR is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants