Panache Support multiple persistence unit in Hibernate Reactive #50084

lucamolteni · 2025-09-16T13:11:54Z

Integration test for multiple reactive persistence units and Panache
Backported from ORM the handling of different persistence units in entity in Panache
withSession overload to take the PU name
Added Panache.withTransaction overload to select persistence unit
Execute update without entity runs on default session
Use ComputingCache instead of a Map<String, LazyValue>
Keep track of onDemand created sessions to close them accordingly
create map of entity => PU in kotlin as well (identical to what happens in Hibernate ORM)
Aligned reactive blocking to orm repositories by using @GenerateBridge to call getSession
getSession shouldn't be static to be substituted by @GenerateBridge
Updated Panache documentation

Release Notes: Hibernate Reactive Panache Enhancements

Complete support for multiple persistence units in Hibernate Reactive Panache, bringing feature parity with Hibernate ORM
Panache.

New API Methods:

// Specify persistence unit for sessions
@WithSession("secondary")

or

Panache.withSession("secondary", () -> { ... })

// Specify persistence unit for transactions  
@WithTransaction("secondary")

or

Panache.withTransaction("secondary", () -> { ... })

// Repository operations work with entity's configured PU
secondaryRepository.findAll() // Uses "secondary" PU automatically

Kotlin Module Independence

The Hibernate Reactive Panache Kotlin module has been changed to depend only on the hibernate-reactive-panache-common module, aligning it to the ORM version.
Backwards compatibility is maintained through a copy of Panache class inside the Kotlin module

// New primary class for Kotlin users
io.quarkus.hibernate.reactive.panache.kotlin.Panache

// Deprecated compatibility class  
io.quarkus.hibernate.reactive.panache.Panache // @Deprecated

The copied class will be eventually removed

Fixes this reproducer reported by a user

FroMage

Answered inline

...rc/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/AbstractJpaOperations.java

...me/src/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/SessionOperations.java

...te-reactive-panache/runtime/src/main/java/io/quarkus/hibernate/reactive/panache/Panache.java

...e-panache/runtime/src/main/java/io/quarkus/hibernate/reactive/panache/PanacheEntityBase.java

...nache/runtime/src/main/java/io/quarkus/hibernate/reactive/panache/PanacheRepositoryBase.java

...-reactive-panache/src/test/java/io/quarkus/it/panache/reactive/PanacheFunctionalityTest.java

...rc/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/AbstractJpaOperations.java

lucamolteni · 2025-09-30T09:46:09Z

I've tackled most of the comments and the current tests are passing

I still need to add a few more test for the named persistence unit overload

github-actions · 2025-09-30T10:22:00Z

🙈 The PR is closed and the preview is expired.

...rc/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/AbstractJpaOperations.java

...me/src/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/SessionOperations.java

...nache/runtime/src/main/java/io/quarkus/hibernate/reactive/panache/PanacheRepositoryBase.java

lucamolteni · 2025-10-01T08:59:45Z

setting "ready for review" as I need CI

lucamolteni · 2025-10-01T15:29:46Z

Tests are passing now! I think it can be reviewed now

...me/src/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/SessionOperations.java

lucamolteni · 2025-10-03T12:56:27Z

@FroMage thanks to @yrodiere today I managed to do this I think it should be what you were thinking about, please take a look

docs/src/main/asciidoc/hibernate-reactive-panache.adoc

FroMage · 2025-10-13T10:25:48Z

Anyway... as far as I can see @lucamolteni didn't change the keys themselves, so it should still work fine?

Well, depends, if on our end we set the value to be a List (of sessions) while on the HR side they expect the value to be a single session, things will break.

yrodiere · 2025-10-13T10:39:54Z

Anyway... as far as I can see @lucamolteni didn't change the keys themselves, so it should still work fine?

Well, depends, if on our end we set the value to be a List (of sessions) while on the HR side they expect the value to be a single session, things will break.

AFAIU the things we changed that way are strictly Panache-specific: https://github.com/quarkusio/quarkus/pull/50084/files#diff-22c7ded8d8a11870b590c9c653f8884dffad2727677e07d2c306fb99b48726ebR65-R68

The important one, shared with Hibernate Reactive, didn't change in such a way.

But anyway, tests will tell.

lucamolteni · 2025-10-13T14:09:52Z

That's... an odd choice, because it effectively means withSession:

Has a very different behavior than org.hibernate.SessionFactory#inSession, which always opens a new session.

Cannot be used to force opening a new session.

Anyway... as far as I can see @lucamolteni didn't change the keys themselves, so it should still work fine?

I would suggest adding a test specifically for this (hidden) feature if there isn't one already, checking that sessionFactory.withSession(...) will reuse the session opened by @WithSession/@WithSessionOnDemande, and vice-versa?

Then we're good to merge.

See #50532

yrodiere

There's one very suspicious test, but if you're sure of what you're doing...

...o/quarkus/hibernate/reactive/panache/test/multiple_pu/MultiplePersistenceUnitConfigTest.java

...-panache/src/main/java/io/quarkus/it/panache/secondary/SecondaryPersistenceUnitEndpoint.java

Addressed

FroMage · 2025-10-15T13:14:10Z

So, do we merge this? I can start rebasing Panache 2 on this then.

lucamolteni · 2025-10-15T13:27:59Z

So, do we merge this? I can start rebasing Panache 2 on this then.

Updated the test and rebased

* Integration test for multiple reactive persistence units and Panache Backported from ORM the handling of different persistence units in entity in Panache * `@WithSessionOnDemand` works only with the default persistence unit * withSession overload to take the PU name * Execute update without entity runs on default session * Repository flush() flushes all PUs Refactor * Use ComputingCache instead of a Map<String, LazyValue> * Keep track of onDemand created sessions to close them accordingly * create map of entity => PU in kotlin as well (identical to what happens in Hibernate ORM) * Aligned reactive blocking to orm repositories by using @GenerateBridge to call getSession * getSession shouldn't be static to be substituted by @GenerateBridge * Added Panache.withTransaction overload to select persistence unit * Updated Panache documentation * Support @WithSession("pu-name") and @WithTransaction("pu-name") * Added test to verify the same session is used * Removed dependency from Kotlin panache module to Java, created two new Panache classes inside the Kotlin module and changed the tests accordingly.

quarkus-bot · 2025-10-15T16:18:10Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 26e8896.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-10-15T17:20:00Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 26e8896.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

❌ io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

FroMage · 2025-10-16T10:25:19Z

Yay! 🥳

yrodiere · 2025-10-16T11:34:10Z

Congrats @lucamolteni :)

@gsmet , oddly the bot assigned milestone 3.29.0.CR1 to this PR. I merged it yesterday evening, so I would have expected 3.30.something... ?

Did you postpone the release? If so we will need to update the @Deprecated(since = ...) in this PR.

lucamolteni requested review from FroMage and yrodiere September 16, 2025 13:12

quarkus-bot bot added the area/panache label Sep 16, 2025

lucamolteni changed the title ~~[DRAFT] Panache Support multiple persistence unit in Hibernate Reactive~~ DRAFT Panache Support multiple persistence unit in Hibernate Reactive Sep 16, 2025

FroMage requested changes Sep 16, 2025

View reviewed changes

yrodiere reviewed Sep 19, 2025

View reviewed changes

...rc/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/AbstractJpaOperations.java Outdated Show resolved Hide resolved

lucamolteni force-pushed the reproducer-multiple branch 2 times, most recently from 577434e to 500587e Compare September 30, 2025 09:44

lucamolteni requested review from FroMage and yrodiere September 30, 2025 09:45

FroMage requested changes Sep 30, 2025

View reviewed changes

lucamolteni force-pushed the reproducer-multiple branch 2 times, most recently from 99cd94a to 74882ef Compare October 1, 2025 08:59

lucamolteni marked this pull request as ready for review October 1, 2025 08:59

lucamolteni changed the title ~~DRAFT Panache Support multiple persistence unit in Hibernate Reactive~~ Panache Support multiple persistence unit in Hibernate Reactive Oct 1, 2025

This comment has been minimized.

Sign in to view

lucamolteni force-pushed the reproducer-multiple branch from 3d9896f to f668331 Compare October 1, 2025 13:42

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Oct 1, 2025

lucamolteni requested a review from FroMage October 1, 2025 15:27

FroMage requested changes Oct 2, 2025

View reviewed changes

...me/src/main/java/io/quarkus/hibernate/reactive/panache/common/runtime/SessionOperations.java Outdated Show resolved Hide resolved

lucamolteni force-pushed the reproducer-multiple branch from f668331 to 53b91ab Compare October 3, 2025 12:43

yrodiere previously requested changes Oct 11, 2025

View reviewed changes

docs/src/main/asciidoc/hibernate-reactive-panache.adoc Show resolved Hide resolved

FroMage mentioned this pull request Oct 13, 2025

Reactive Sessions opened by Panache outside the Mutiny.SessionFactory#withSession callback are not shared with withSession #50532

Open

lucamolteni force-pushed the reproducer-multiple branch from 484a717 to de52802 Compare October 14, 2025 15:52

lucamolteni requested review from FroMage and yrodiere October 14, 2025 15:53

This comment has been minimized.

Sign in to view

lucamolteni force-pushed the reproducer-multiple branch from de52802 to 325830e Compare October 15, 2025 08:53

This comment has been minimized.

Sign in to view

FroMage approved these changes Oct 15, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

yrodiere reviewed Oct 15, 2025

View reviewed changes

...o/quarkus/hibernate/reactive/panache/test/multiple_pu/MultiplePersistenceUnitConfigTest.java Show resolved Hide resolved

...-panache/src/main/java/io/quarkus/it/panache/secondary/SecondaryPersistenceUnitEndpoint.java Outdated Show resolved Hide resolved

lucamolteni force-pushed the reproducer-multiple branch from 325830e to 95a4f04 Compare October 15, 2025 13:27

This comment has been minimized.

Sign in to view

lucamolteni force-pushed the reproducer-multiple branch from 95a4f04 to 26e8896 Compare October 15, 2025 15:39

yrodiere merged commit 44ec5f4 into quarkusio:main Oct 15, 2025
33 checks passed

quarkus-bot bot added this to the 3.29 - main milestone Oct 15, 2025

quarkus-bot bot added the kind/enhancement New feature or request label Oct 15, 2025

Panache Support multiple persistence unit in Hibernate Reactive #50084

Panache Support multiple persistence unit in Hibernate Reactive #50084

Uh oh!

Conversation

lucamolteni commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes: Hibernate Reactive Panache Enhancements

New API Methods:

Kotlin Module Independence

Uh oh!

FroMage left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucamolteni commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucamolteni commented Oct 1, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lucamolteni commented Oct 1, 2025

Uh oh!

Uh oh!

lucamolteni commented Oct 3, 2025

Uh oh!

Uh oh!

FroMage commented Oct 13, 2025

Uh oh!

yrodiere commented Oct 13, 2025

Uh oh!

lucamolteni commented Oct 13, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

yrodiere left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FroMage commented Oct 15, 2025

Uh oh!

lucamolteni commented Oct 15, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

quarkus-bot bot commented Oct 15, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

quarkus-bot bot commented Oct 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

Uh oh!

Uh oh!

FroMage commented Oct 16, 2025

Uh oh!

yrodiere commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

lucamolteni commented Sep 16, 2025 •

edited

Loading

github-actions bot commented Sep 30, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Oct 15, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`

yrodiere commented Oct 16, 2025 •

edited

Loading