Do not show 0.0.0.0 in a url #50347
Open
Do not show 0.0.0.0 in a url #50347
+55
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Sep 30, 2025
closes: quarkusio#50231 Signed-off-by: Steve Hawkins <[email protected]>
Yeah, this would be really nice to see |
The description reflects the latest changes. |
|
I like the latest incarnation of this |
shawkins
commented
Oct 3, 2025
| serverListeningMessage.append(" and "); | ||
| } | ||
| serverListeningMessage.append(String.format("unix:%s", getDeveloperFriendlyHostName(domainSocketOptions))); | ||
| serverListeningMessage.append(String.format("unix:%s", domainSocketOptions.getHost())); |
There was a problem hiding this comment.
Domain sockets don't understand the any address concept, so we don't need special handling here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bind address 0.0.0.0 for all addresses should not be shown in the logs in a url.
Previously one might see:
Listening on: https://0.0.0.0:8444
An initial proprosal with this pr would show:
Listening on: all addresses on port 8444 for https (e.g. https://127.0.0.1:8444)
This was refined to be less verbose:
Listening on: all addresses including https://localhost:8444