-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix a few issues with Java 25 compatibility and include Java 25 in CI #50351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...rojects/arc/processor/src/main/java/io/quarkus/arc/processor/InterceptionProxyGenerator.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
<jakarta.enterprise.cdi-api.version>4.1.0</jakarta.enterprise.cdi-api.version> | ||
<jandex.version>3.5.0</jandex.version> | ||
<bytebuddy.version>1.15.11</bytebuddy.version> | ||
<bytebuddy.version>1.17.6</bytebuddy.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this would be important indeed
f99bc5e
to
48d8fbd
Compare
36b98c9
to
afaeee6
Compare
This comment has been minimized.
This comment has been minimized.
Artemis uses the SecurityManager which has been dropped from Java 25. See https://issues.apache.org/jira/browse/ARTEMIS-4975
0a8a7ab
to
4863efe
Compare
Status for workflow
|
🎊 PR Preview 619daa1 has been successfully built and deployed to https://quarkus-pr-main-50351-preview.surge.sh/version/main/guides/
|
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🚧 | ||
✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🚧 | ||
✔️ | JVM Tests - JDK 25 | Logs | Raw logs | 🚧 | ||
❌ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🚧 |
⌛ | Native Tests - Virtual Thread - Messaging | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 Windows #
- Failing: devtools/gradle/gradle-application-plugin
📦 devtools/gradle/gradle-application-plugin
❌ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.6.0:exec (gradle) on project io.quarkus.gradle.plugin: Command execution failed.
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/infinispan-cache/deployment
❌ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls
- History
expected: "thread1" but was: "thread2"
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError:
expected: "thread1"
but was: "thread2"
at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:285)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)
at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:448)
📦 test-framework/jacoco/runtime
❌ io.quarkus.jacoco.runtime.DataFileWatchTest.waitForPreexistingDataFileThatNeverChanges
- History
Expecting value to be false but was true
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError:
Expecting value to be false but was true
at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForPreexistingDataFileThatNeverChanges(DataFileWatchTest.java:241)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Expecting value to be false but was true
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError:
Expecting value to be false but was true
at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForPreexistingDataFileThatNeverChanges(DataFileWatchTest.java:241)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Expecting value to be false but was true
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError:
Expecting value to be false but was true
at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForPreexistingDataFileThatNeverChanges(DataFileWatchTest.java:241)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
⚙️ JVM Tests - JDK 25
📦 extensions/smallrye-graphql/deployment
❌ io.quarkus.smallrye.graphql.deployment.CompletionStageTest.testSourcePost
- History
1 expectation failed. Expected status code <200> but was <500>.
-java.lang.AssertionError
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <500>.
at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)
at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
⚙️ JVM Tests - JDK 17 Windows
📦 independent-projects/resteasy-reactive/server/vertx
❌ org.jboss.resteasy.reactive.server.vertx.test.sse.SseServerTestCase.shouldCallOnCloseOnServer
- History
1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false
-java.lang.AssertionError
java.lang.AssertionError:
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
Actual: false
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
I think we are good to go now, as far as CI is concerned. |
@Ladicek @mkouba @manovotn asking for your review as I had to change something in ArC (more info in the commit message)
@Ladicek pinging you also because you might need to adjust the Gizmo 2 port if we merge this.