Fix handling of overlapping paths in resteasy-reactive server #50384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasHofman
changed the title
quarkus-bot
bot
added
area/agroal
area/amazon-lambda
area/arc
geoand
removed
area/health
area/fault-tolerance
area/mutiny
area/google-cloud-functions
area/codestarts
area/cli
|
Thanks @TomasHofman! Did this pass CI on your fork? |
|
Hi @geoand , I was locally running tests in following two modules:
and those did pass. I was hoping to get more coverage here on the PR. Now as I reread the contributors file I will get GH actions working on my fork and let you know 👍 (it's been few years since I last contributed here). |
|
@geoand actually the CI on my fork had run, and looks green (if you can access here? https://github.com/TomasHofman/quarkus/actions/runs/18191107425) |
geoand
reviewed
Oct 3, 2025
| .body(equalTo("Foo bar_value")); | ||
| } | ||
|
|
||
| // TODO: remove this test before commit |
There was a problem hiding this comment.
I assume this need to be removed :)
|
Cool! In that case, feel free to take it out of draft when you are done |
|
@geoand sure, I will take bit more time, I'm looking at one more touch point. |
|
Thanks! No rush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the path matching logic in resteasy-reactive server. It fixes the case when there are overlapping path templates registered, such as:
and the incoming request has path
/path/foo/bar_something. The expectation is that this path should be matched by the first template. The current behavior however is that server returns 404.