Rework reconciliations not to use steps based on status #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a "send on closed channels" panic when multiple errors were returned - Add wait group context cancelation - End permissions tasks on first error raised
vincentmrg
force-pushed
the
release/0.13.0
branch
from
5e8ebce to
bb3d98b
Compare
Co-authored-by: Antonin <[email protected]>
And fix comment-spacings: no space between comment delimiter and comment text
antonincms
force-pushed
the
release/0.13.0
branch
from
e7f824d to
ce31565
Compare
…ewallRule condition (#171)
* Add cache mechanism in the provider * Add a cache per resource requested and flush when cache is subjected to changes * Use flags to set cache entries ttl and cache cleanup intervals. Use super function to get instances and network interfaces. * Add a mutex per cache * Bump chart to 0.13.0-rc.3
Sometimes we would have a bug where a deleted but cached resource would be reconciled after the finalizer is removed.
antonincms
reviewed
Mar 31, 2025
There was a problem hiding this comment.
Hello @klibr007, thanks for the PR.
Here is a first set of review comments.
antonincms
reviewed
Apr 2, 2025
* Upgrade go to 1.23.0 * Upgrade golangci-lint to 2.0.2 in CI and Makefile * Fix new warnings
* Update aws package to v2 and remove unnecessary v1 use * Update packages * Use rand.String and remove unnecessary internal/utils package * Put lock on mutexes before it is flushed
Remove unecessary lock on securitygroup mutex Invalidate key in instancesCache on network interface modification
* Update the chart to use the cluster-id value * Bump chart to 0.13.0-rc.7
* Add imds to retrieve vpcid when needed * Update readme
* Test for aws provider reconciliation functions and small fixes * Rename file and change ec2api to ec2client and small changes * Update the tests * Rename files and add mockgen in makefile * Add changes check in github action * Renames files and fixes tests * Renames files and fixes tests * Check the error code and the message when an error occurres in the tests * Update tests * Update internal/provider/aws/provider_test.go --------- Co-authored-by: Antonin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.