Skip to content

Conversation

tnederlof
Copy link

CANNOT MERGE until connectcreds release

Addresses: #930

@atheriel atheriel self-assigned this Aug 21, 2025
This commit adds support for service principal credentials managed by
Posit Connect alongside our existing support of viewer-based
credentials. The meat of this is handled by a new function in the
upcoming version of the `connectcreds` package (hence the Remote).

Documentation updates are included.

Co-authored-by: Aaroon Jacobs <[email protected]>
@atheriel atheriel force-pushed the connectcreds-serviceaccount branch from 4103d9f to 288ec4c Compare August 21, 2025 16:21
@atheriel
Copy link
Collaborator

I backed out the formatting-only changes from this and squashed + rebased the commits. I also set the Remote so that we pick up on the dev version of the package, which should allow CI to pass.

@simonpcouch
Copy link
Collaborator

Thank you!! Do yall want to see this change going in the odbc release to be submitted early next week? If so, on what timeline would you imagine connectcreds would be submitted to CRAN?

))
}

if (is_installed("connectcreds") && connectcreds::has_service_account_token(workspace)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also just add a conditional on the connectcreds package version here, I think? And then merge without a Remotes on the dev version.

@atheriel
Copy link
Collaborator

@simonpcouch We haven't been able to get it to work yet, so I'd say no, don't hold up the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants