Skip to content

fix compilation warnings on Niagara clusters #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix compilation warnings on Niagara clusters #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/include/cpp11/doubles.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ inline void r_vector<double>::get_region(SEXP x, R_xlen_t i, R_xlen_t n,
typename r_vector::underlying_type* buf) {
// NOPROTECT: likely too costly to unwind protect here
REAL_GET_REGION(x, i, n, buf);
};
}

template <>
inline bool r_vector<double>::const_iterator::use_buf(bool is_altrep) {
Expand Down
2 changes: 1 addition & 1 deletion inst/include/cpp11/integers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ inline void r_vector<int>::get_region(SEXP x, R_xlen_t i, R_xlen_t n,
typename r_vector::underlying_type* buf) {
// NOPROTECT: likely too costly to unwind protect here
INTEGER_GET_REGION(x, i, n, buf);
};
}

template <>
inline bool r_vector<int>::const_iterator::use_buf(bool is_altrep) {
Expand Down
2 changes: 1 addition & 1 deletion inst/include/cpp11/list.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ template <>
inline void r_vector<SEXP>::get_region(SEXP x, R_xlen_t i, R_xlen_t n,
typename r_vector::underlying_type* buf) {
cpp11::stop("Unreachable!");
};
}

template <>
inline bool r_vector<SEXP>::const_iterator::use_buf(bool is_altrep) {
Expand Down
2 changes: 1 addition & 1 deletion inst/include/cpp11/logicals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ inline void r_vector<r_bool>::get_region(SEXP x, R_xlen_t i, R_xlen_t n,
typename r_vector::underlying_type* buf) {
// NOPROTECT: likely too costly to unwind protect here
LOGICAL_GET_REGION(x, i, n, buf);
};
}

template <>
inline bool r_vector<r_bool>::const_iterator::use_buf(bool is_altrep) {
Expand Down
4 changes: 2 additions & 2 deletions inst/include/cpp11/r_vector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ inline r_vector<T>& r_vector<T>::operator=(const r_vector& rhs) {
length_ = rhs.length_;

return *this;
};
}

// Same reasoning as `r_vector(r_vector&& x)` constructor
template <typename T>
Expand All @@ -446,7 +446,7 @@ inline r_vector<T>& r_vector<T>::operator=(r_vector&& rhs) {
rhs.length_ = 0;

return *this;
};
}

template <typename T>
inline r_vector<T>::operator SEXP() const {
Expand Down
2 changes: 1 addition & 1 deletion inst/include/cpp11/raws.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ inline void r_vector<uint8_t>::get_region(SEXP x, R_xlen_t i, R_xlen_t n,
typename r_vector::underlying_type* buf) {
// NOPROTECT: likely too costly to unwind protect here
RAW_GET_REGION(x, i, n, buf);
};
}

template <>
inline bool r_vector<uint8_t>::const_iterator::use_buf(bool is_altrep) {
Expand Down
2 changes: 1 addition & 1 deletion inst/include/cpp11/strings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ template <>
inline void r_vector<r_string>::get_region(SEXP x, R_xlen_t i, R_xlen_t n,
typename r_vector::underlying_type* buf) {
cpp11::stop("Unreachable!");
};
}

template <>
inline bool r_vector<r_string>::const_iterator::use_buf(bool is_altrep) {
Expand Down
Loading