Skip to content

Add tests for snapshots with different extensions #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 8, 2025
Merged

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Jul 24, 2025

This adds two tests that pass on current main to help having a baseline for #2029. Following the discussion I've opened in #2106, we may add another test too (plus any other that may be suggested).

@hadley
Copy link
Member

hadley commented Aug 8, 2025

Thanks for getting started on this — as it looked the tests I remembered that a lot of these differences are due to the slightly different paths that expect_snapshot() and expect_snapshot_file() generate so I've tweaked the tests to hopefully make that more clear.

@hadley hadley merged commit 8fa672d into r-lib:main Aug 8, 2025
10 of 11 checks passed
@mcol mcol deleted the issue_2106 branch August 8, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants