Skip to content

Avoid 0-length copy with potentially undefined behavior #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoid 0-length copy with potentially undefined behavior #1968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad50279
Avoid 0-length copy with potentially undefined behavior
MichaelChirico Apr 16, 2025
ca58a9d
Add a new regression test for 2nd case
MichaelChirico Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,9 @@ SEXP df_map(SEXP df, SEXP (*fn)(SEXP)) {
\
r_ssize copy_size = (size > x_size) ? x_size : size; \
\
memcpy(p_out, p_x, copy_size * sizeof(CTYPE)); \
if (copy_size > 0) { \
memcpy(p_out, p_x, copy_size * sizeof(CTYPE)); \
} \
\
UNPROTECT(1); \
return out; \
Expand Down
5 changes: 5 additions & 0 deletions tests/testthat/test-set.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@ test_that("works with rcrds", {
expect_identical(vec_set_union(y, x), vec_c(vec_slice(y, c(1, 2, 3, 4)), vec_slice(x, 1)))
})

test_that("works on empty inputs", {
expect_identical(vec_set_union(integer(), 12L), 12L)
expect_identical(vec_set_union(12L, integer()), 12L)
})

# vec_set_symmetric_difference --------------------------------------------

test_that("retains names of `x` and `y` elements", {
Expand Down
Loading