Skip to content

fix: stuck on splash page #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfredoheights
Copy link

@alfredoheights alfredoheights commented Aug 22, 2024

What's wrong?

On my own device, I've found that I get stuck on the splash page indefinitely if the app crashes. The exitUnknownPage function looks like it's clicking and dragging out of the button, resulting in the button not actually being clicked.

This bug has only been reported to occur on a OnePlus 8T and I'm not sure it affects anyone else.

What is changed?

I've added some more taps for good measure (and because it won't work for me otherwise), and updated the during parameter for each so that the game recognizes the taps as taps, rather than dragging.

What's next?

I don't know if this affects anyone else's devices, and I'd like to test it on some other unrecognized pages to make sure we don't get stuck on those.

This bug has only been reported to occur on a OnePlus 8T (by me) and I'm not sure it affects anyone else.
@alfredoheights alfredoheights force-pushed the alfredoheights-2024-08-22-splash-page-unknown branch from 254b03b to 12c3d0a Compare August 22, 2024 16:47
// msg += "R:"+ts.record['hearts_count'].receivedCount+" ";
// msg += "S:"+ts.record['hearts_count'].sentCount;
// add timestamp in HH:MM:SS
msg += new Date().toTimeString().split(' ')[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to leave these changes in this pull request, or did you change the message just for local debugging? If intended, feel free to delete the old counting parts instead of commenting them out.

I'm not sure if anyone might be unhappy about this change. It is an easy way to check own stats without explicit tracking and creating reports, but timestamps on the other hand are indeed much more helpful if there is need for troubleshooting.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, forgot to take this out, thanks. Will do that.

I think it might be useful to have this as an option (like the debug logs) but that should be its own pull request if so.

this.tap(Button.gameQuestionCancel2);
this.tap(Button.outClose);
this.tap(Button.gameStop);
this.tap(Button.outSplashPageTapToStart, 250);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you checked that adding the 2nd ms parameter works as you expect, because for the CLY skill, I needed to add explicit sleep statements between taps. Just a hint - if it works for your problem this way, is's fine :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants