Skip to content

Search in Catalog shows the total number of records found #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

constantinius
Copy link
Collaborator

Adding new field to state apiItemsNumberMatched which sets the value from numberMatched if available.
Items in Catalog are now provided with the count from that new field

Closes #606

…e from `numberMatched` if available.

`Items` in `Catalog` are now provided with the `count` from that new field
@constantinius constantinius requested a review from m-mohr as a code owner June 11, 2025 16:09
Copy link
Collaborator Author

@constantinius constantinius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an issue when a search hits no records, the old number is then still visible.

@constantinius
Copy link
Collaborator Author

Fixed.

@constantinius constantinius requested review from m-mohr and removed request for m-mohr June 13, 2025 14:07
@m-mohr
Copy link
Collaborator

m-mohr commented Jun 13, 2025

I've seen this, but review will probably take until after LPS at least, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numberMatched not used in Catalog search
2 participants