feat: debug mode #1254
feat: debug mode #1254
Conversation
This would enable an interative shell to be opened up if a build fails. This is still experimental and I'm running into some issues using this with orbstack, so this PR is still very much a WIP. orbstack/orbstack#1700 Without this option, the only way to debug a failing build is to `--out` the build, insert multi-stage build commands in the dockerfile and then use `--target` to get in-progress container ID to play around with, which is super lame. We need a better way.
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder about this pull request! Please let me know if there is anything else that needs to be addressed. |
|
is there a way to mark these issues as OK to leave around for the issue bot? I'm just copying pasting those messages above to keep the issue open. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder on this pull request! Let me know if there's anything else that needs to be addressed here. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder regarding this pull request! Let me know if there are any further updates needed. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder about this pull request! Let me know if there are any updates or additional tasks needed. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Just a friendly reminder on this pull request! Let me know if you need any further assistance. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder about this pull request! Let me know if there are any updates needed. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder about this pull request! Let me know if there are any updates or additional changes needed. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder regarding this pull request. Please provide an update or let me know if there are any outstanding tasks. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder on this pull request! Let me know if there are any updates or additional changes needed. |
| .arg("buildx") | ||
| .arg("debug") | ||
| .arg("--invoke") | ||
| .arg("bash") |
There was a problem hiding this comment.
I think this should only be changed if the debug flag is set?
| @@ -36,11 +36,14 @@ fn get_output_dir(app_src: &str, options: &DockerBuilderOptions) -> Result<Outpu | |||
| } | |||
| } | |||
|
|
|||
| // TODO need to quote the output here otherwise the build command will fail with special char ENV vars | |||
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Just a friendly reminder on this pull request! Let me know if there are any updates or additional changes needed. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder about this pull request! Let me know if there are any updates needed. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder regarding this pull request. Let me know if there are any updates or additional tasks needed. |
This would enable an interative shell to be opened up if a build fails. This is still experimental
and I'm running into some issues using this with orbstack, so this PR is still very much a WIP.
orbstack/orbstack#1700
Without this option, the only way to debug a failing build is to
--outthe build, insert multi-stagebuild commands in the dockerfile and then use
--targetto get in-progress container ID to play aroundwith, which is super lame. We need a better way.