Adds nx 20 support #1322
Open
Adds nx 20 support #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys, I have some time this week to get this merged. I'll wait for coments 🙂 |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
@coffee-cup hi there! Sorry to bother you, I know you guys must be busy. Is there any maintainer that could take a look at this pr? Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since nx 20, project.json is optional, and instead project configurations can be placed in the package.json under the nx property.
This makes NX detection fail on these cases, which are the de-facto setup for newer NX versions.
See: nrwl/nx#30464 (comment)
This PR addresses that and improves NX detection, while maintaining the legacy way of doing it.
Please note that im not a Rust guy, so all feedback is more than welcome.