Skip to content

fix: GQA QKV code comments #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix: GQA QKV code comments #660

merged 1 commit into from
Jun 13, 2025

Conversation

d-kleine
Copy link
Contributor

fixes #654

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d-kleine d-kleine marked this pull request as ready for review June 13, 2025 10:03
@rasbt
Copy link
Owner

rasbt commented Jun 13, 2025

Thanks for fixing!

@rasbt rasbt merged commit c2cfb47 into rasbt:main Jun 13, 2025
13 checks passed
@d-kleine d-kleine deleted the gqa_qkv_comments branch June 13, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GQA - QKV shape code comments
2 participants