Add support for extra security bit #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
approved these changes
Aug 22, 2025
lurch
reviewed
Aug 22, 2025
main.cpp
Outdated
| @@ -3361,6 +3361,10 @@ void info_guts(memory_access &raw_access, void *con) { | |||
| if (image_def->tbyb()) { | |||
| info_pair("tbyb", "not bought"); | |||
| } | |||
|
|
|||
| if (image_def->extra_security() && verbose_metadata) { | |||
| info_pair("extra security", "enabled"); | |||
There was a problem hiding this comment.
Should it print info_pair("extra security", "not enabled") if the flag hasn't been set? 🤔
There was a problem hiding this comment.
Yes, that's a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set this by default when signing Arm images, in addition to adding a vector table and entry point if they're not present
This bit has no effect on chip revisions <A4, on A4 it requires that the image has both a vector table and an entry point