-
Notifications
You must be signed in to change notification settings - Fork 617
[Bug] Fix health probes to use custom ports from rayStartParams #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@kevin85421 PTAL~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me add an integration test to prove it?
And also provide a screenshot and a yaml file to show me how you test it, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with the following YAML, and it worked well. Thanks!
apiVersion: ray.io/v1
kind: RayCluster
metadata:
name: raycluster-kuberay
spec:
rayVersion: '2.46.0'
headGroupSpec:
rayStartParams:
dashboard-port: "8266"
dashboard-agent-listen-port: "8267"
template:
spec:
containers:
- name: ray-head
image: rayproject/ray:2.46.0
resources:
limits:
cpu: 1
memory: 2G
requests:
cpu: 1
memory: 2G
ports:
- containerPort: 6379
name: gcs-server
- containerPort: 8266 # Ray dashboard
name: dashboard
- containerPort: 10001
name: client

In v1.5.0 we might modify the liveness and readiness probes when we get rid of |
Co-authored-by: Jun-Hao Wan <[email protected]> Signed-off-by: Itami Sho <[email protected]>
What type of PR is this?
Bug fix
What this PR does / why we need it:
This PR fixes an issue where the liveness and readiness probes in Ray pods were hardcoded to use default ports, ignoring custom port configurations specified in
rayStartParams
. This caused probe failures when users customized ports likedashboard-port
ordashboard-agent-listen-port
.Which issue(s) this PR fixes:
Fixes health probe failures when custom ports are configured in rayStartParams.
Special notes for your reviewer:
The fix extracts port values from
rayStartParams
with fallback to default values, ensuring probes use the correct ports that Ray processes are actually listening on.