[Feature] Add allow CORS in apiserversdk #4059
Open
+19
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheyu Wu <[email protected]>
CheyuWu
force-pushed
the
feat/apiserversdk/cors
branch
from
3c3dfcc to
d5908bb
Compare
rueian
reviewed
Sep 7, 2025
apiserver/cmd/main.go
Outdated
| KubernetesConfig: kubernetesConfig, | ||
| }) | ||
| } | ||
| if *corsAllowOrigin != "" { |
There was a problem hiding this comment.
Is it possible to merge these into the similar block below?
CheyuWu
force-pushed
the
feat/apiserversdk/cors
branch
from
7e98a23 to
1a443e3
Compare
|
Hi @rueian PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, there is no allow CORS origin in the apiserversdk. So, we can add a middleware in apiserversdk if corsAllowOrigin is not an empty string.
Manaual Testing
$ go run cmd/main.go -httpPortFlag :31888 -cors-allow-origin=* // another terminal $ yarn devRelated issue number
Closes #4058
Checks