[HashShuffle] - Add warnings for when there are insufficient resources for Aggregators #53705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goutamvenkat-anyscale
force-pushed
the
goutam/hash_shuffle_logging
branch
2 times, most recently
from
5f03c85 to
935f5ec
Compare
goutamvenkat-anyscale
force-pushed
the
goutam/hash_shuffle_logging
branch
from
b41cee0 to
763e6e0
Compare
…s for Aggregators Signed-off-by: goutam <[email protected]> Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
goutamvenkat-anyscale
force-pushed
the
goutam/hash_shuffle_logging
branch
from
03232e7 to
83bb03b
Compare
goutamvenkat-anyscale
added
go
Signed-off-by: Goutam V <[email protected]>
goutamvenkat-anyscale
added
go
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
alexeykudinkin
approved these changes
Jun 18, 2025
|
@goutamvenkat-anyscale enabled auto-merge please update the message before merging |
Signed-off-by: Goutam V <[email protected]>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…s for Aggregators (ray-project#53705) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? Improve the observability for hash based shuffling. ## What is the change? 1. At the start of executing HashShufflingOperatorBase, check if the cluster has enough resources to schedule all actors, if not we can fail outright. 2. Add a warning to continue observing if all of the Aggregators are up and running after a period of 30 secs (configurable), if not print a warning. ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: goutam <[email protected]> Signed-off-by: Goutam V <[email protected]> Co-authored-by: Goutam Venkatramanan <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
…s for Aggregators (#53705) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? Improve the observability for hash based shuffling. ## What is the change? 1. At the start of executing HashShufflingOperatorBase, check if the cluster has enough resources to schedule all actors, if not we can fail outright. 2. Add a warning to continue observing if all of the Aggregators are up and running after a period of 30 secs (configurable), if not print a warning. ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: goutam <[email protected]> Signed-off-by: Goutam V <[email protected]> Co-authored-by: Goutam Venkatramanan <[email protected]> Signed-off-by: elliot-barn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Improve the observability for hash based shuffling.
What is the change?
At the start of executing HashShufflingOperatorBase, check if the cluster has enough resources to schedule all actors, if not we can fail outright.
Add a warning to continue observing if all of the Aggregators are up and running after a period of 30 secs (configurable), if not print a warning.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.