Feature/vplay 9862 #186
Open
Feature/vplay 9862 #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Removing uncompiled dead code as part of RDK-56189 Test Procedure: N/A Risks: Low Priority: P1 Change-Id: I9c681be30018289f545a7db8e3d07c60d6e3f2a7 Signed-off-by: Alsameema.A <[email protected]>
Reason for change: Null check before accessing mpStreamAbstractionAAMP instance Test Procedure: As mentioned in the ticket Risks: None Change-Id: Ia833004a3da5170592074289767b7ed10792bb37 Signed-off-by: Vinish K B <[email protected]>
Reason for change: godspell-flagged spelling Test Procedure: no godspell warning Risks: None Change-Id: Ie7653c88c87e8a03d788ddbac7e9d944dca85e49
Reason for change: tech debt - more elegant way to avoid unwanted qtdemux stop Test Procedure: do no harm testing; refer ticket for original issue Risks: Low Change-Id: Id073bc911838f6e12523763a950215a2d4096401
Reason for change: L1 test PrivAampTests.stopTest fails intermittently Changes: * Set rate to PLAY so stopTest verifies pausing the playback * Add small delays to allow thread switching Test Procedure: run L1 PrivAampTests Risks: Low Change-Id: I6d6f4fa58ad6767336ee0d03d3aebd33e166ba4c Signed-off-by: Jose Fagundez <[email protected]>
Reason for change: Help investigate L1 test failures Changes: * Add timestamp to L1 test log lines * Do not rely on AampUtils to print thread ID in L1 test log * Delete commented out code * Delete ENABLE_TEST_LOGGING define, since it is always on for L1 tests Test Procedure: run L1 test with --verbose option Risks: Low Change-Id: I04bacb139ed3e8dff36869259284be6b09e0334b Signed-off-by: Jose Fagundez <[email protected]>
Reason for change: avoid conflicting definitions in middleware header and SubtecChannel.cpp Test Procedure: build in xcode Risks: Low Change-Id: Icf699aa2e80fba40b46b59881db1219b1813d3b4
…d for DASH (not HLS) Reason for change: API documentation unclear about restrictions for the "enablePTSReStamp" configuration option. Test Procedure: Observe the restriction in the documentation. Risks: None Change-Id: I245e793f6b9bf896b39b3846c111fa53b7b0c6e8
Reason for change: deprecate IsValidRate, common getSupportedRates Test Procedure: l1 tests and no x1 bugs related to trickplay Risks: Low Change-Id: I0f76d768e0c21e498bc06b86aacadda7a793b9a2
Reason for change: Make it easier to port changes to branches like 8.1 Changes: * Rename MockAampJsonObject get_string() to get() to match MockPlayerJsonObject Test Procedure: Run L1 tests Risks: Low Change-Id: I54bf44f3f68acec52dca1e4994bb021927e7cacd Signed-off-by: Jose Fagundez <[email protected]>
…Cold CDVR transition Reason for change: positions values are not calculated when manifest transitions from dynamic to static Test Procedure: Test case updated in the ticket Risks: Medium Change-Id: I1f05691195186fcabd1e159f3aeb2bdaab9209f8 Signed-off-by: haripriya_molakalapalli <[email protected]>
Reason for change: fix parsing edge case Test Procedure: refer ticket Risks: Low Change-Id: Iaf079651e78e231dbd35c02dd14b2cbeb5e8221b
Reason for change: WebProcess crashes in AampCache::Remove due to assertion `iter2 != cache.end()' This is because 2 different URLs resolve to the same effective URL. When the first is removed from the cache the associated effective URL is also removed. As a result when the second URL is removed the associated effective URL no longer exists. This change checks if any other URL reference the effetive URL before removing it. Test Procedure: Run L1 tests, and confirm at full stack the issue is resolved. Risks: Low Signed-off-by: Dominic Holden <[email protected]> Change-Id: Ia63449cf82ceb22e6223643b3d6b02841bdeb977
Reason for change: To update the correct version of openssl to install in the install-aamp script Risks: Low Priority: P0 DEPS_BRANCH=rdk/components/generic/gst-plugins-rdk-aamp:dev_sprint_25_1 DEPS_BRANCH=rdk/components/generic/aampabr:dev_sprint_25_1 DEPS_BRANCH=rdk/components/generic/aampmetrics:dev_sprint_25_1 Change-Id: I6dc8b1e82a8d66853eef3397762d9c3ce79c6820 Signed-off-by: Rajat <[email protected]>
…res as object within header response event Reason for change : send drm meta data upon license request failure Risks: Low Test Procedure: updated in ticket Priority: P1 Change-Id: I6dc96e33fa4198063b79f1aa3e032adf384a9c53 Signed-off-by: Gnanesha <[email protected]>
Reason for change: avoid xcode warnings in this area Test Procedure: warnings no longer seen in xcode Risks: Low - no functional change Change-Id: Ia21937640e8a1c3e331ebc6186d5b0af499ff878
Reason for change: Reworked NotifyEOSReached() to avoid crash when mpStreamAbstractionAAMP gets deleted by SetRate b/w checking for mpStreamAbstractionAAMP not null & IsEOSReached() in different lines. Test Procedure: Refer Jira Risks: Low Change-Id: I121c5e5d528c58f4626ceebcce35544a871a4af6 Signed-off-by: Sivasubramanian <[email protected]>
…RM failures as object within header response event" This reverts commit 69e6897d7db8a460534a66e515e798eb29fd3b91. Reason for revert: causing regression VPLAY-9353 Change-Id: I7f41f480bb39e6fa401842d3c5130a904bce064a
… as object within header response event Reason for change : send drm meta data upon license request failure w/o any crash regression. Added check for invalid response which is not NULL & caused crash in VPLAY-9352 & VPLAY-9353. Test Procedure: Refer ticket Risks: Medium Revert "Revert "RDKAAMP-4128 : [HLS] Support Header/Body response event for DRM failures as object within header response event"" This reverts commit a5c276d0f2a91e2a411d247d69c2aa3bef23aa36. Change-Id: I4a0a7c01007194b34b93ddf07b0d4a99f8c44440 Signed-off-by: Sivasubramanian <[email protected]> VPLAY-9354 Address L1/L2 Test Gap for escaped sprint regression VPLAY-9353 Reason for change: l1 test for aamp_CreateBodyResponseJSObject Test Procedure: needs to be delivered along with fix for regression Risks: Low Change-Id: I7878549a19af9df4dba5829e83f92c61f82d8697 Change-Id: I4a0a7c01007194b34b93ddf07b0d4a99f8c44440 Signed-off-by: Sivasubramanian <[email protected]>
Reason for change: Update AAMP version to 7.05 Test Procedure: Validate version in IP_AAMP_TUNETIME Risks: None Change-Id: I4a92f9304a1ff207df1cc4589de5aeff93f8b239 Signed-off-by: Vinish K B <[email protected]>
Reason for change: Decouple License dependencies to seperate folder. Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: I38c93ca222ccd2dfc594ce66858f07e659d2dc4b Signed-off-by: Deepikasri N <[email protected]
Reason for change: Fixed L3 regression due to deadlock Test Procedure: Refer Jira Risks: Low Change-Id: I46c6d6e1ee3f9b3cff8f297a6c90305ac3b4a20e Signed-off-by: Sivasubramanian <[email protected]>
…n't exist Reason for change: Make the code more robust Test Procedure: Run L1 Risks: Low Change-Id: I6f4df4c958dfcaf5108666dd48b71f6f5b2d82ed Signed-off-by: Vijendra Nagori <[email protected]>
Reason for change: Fixed Godspell errors. Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: I46e780bde7ff057c263c5a98147158e1fa4b5760 Signed-off-by: Deepikasri N <[email protected]
Reason for change: With AAMP TSB active then during pause the segment fetch must continue to write to TSB. Segment inject from TSB reader should stop once enough-data signal is received. Test procedure: Existing L1 and L2 tests. Could not add a specific L2 test as enough-data is not generated in L2. Test at full stack using description in jira. Risks: Medium Change-Id: I6a6cc5afdb938797f78a350d443073a0a7f6d9f8
Reason for change: Threads created by the TSB library did not have the thread-local gPlayerId field set and were therefore reporting a PlayerId of -1 in log messages. This change propogates the PlayerId of the instance which creates a TSB::Store to threads created by that Store. Test Procedure: L1 + L2 tests to confirm no regressions. Check logs for TSB output (specifically, from "Flusher") to ensure the PlayerId is not -1. Risks: Very Low/None. Affects log output only. Change-Id: I787f16836b898f38e5f941226d8f0c4ebf7f5c55
Reason for change: To add the missing #include <cstdint> header in middleware/PlayerLogManager.h resulting in AAMP build failure on Ubuntu Risks: Low Priority: P0 DEPS_BRANCH=rdk/components/generic/gst-plugins-rdk-aamp:dev_sprint_25_1 DEPS_BRANCH=rdk/components/generic/aampabr:dev_sprint_25_1 DEPS_BRANCH=rdk/components/generic/aampmetrics:dev_sprint_25_1 Change-Id: I5bbb4e2b531db6137c752ddaef8fb48014c96006 Signed-off-by: Rajat <[email protected]>
Reason for change: Added sample code for showDiagnosticOverlay Added changelog for 7.05 Test Procedure: None Risks: None Priority: P2 Change-Id: I136d0d9c3ebb55f77d50226b8f279dd5a4515610 Signed-off-by: Vinish K B <[email protected]>
Reason for change : spelling fix and whitelist additions Risks: Low Test Procedure: try sample code in test app Change-Id: I5caa67004694622bd121058ef16ae68743200e03
Reason for change : added support for Thumbnails for SLE and Linear content for seek opeartions Risks: LOW Test Procedure: updated in ticket Priority: P1 Change-Id: Icc2917aff025da629d280ebd4b852b33e215acf8 Signed-off-by: Gnanesha <[email protected]>
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
…dkcentral/aamp into feature/VPLAY-9512_FixWarning2
Feature/vplay 9512 add aamp configuration allowing new mp4demux to be used as alternative to qtdemux
VPLAY-9167:[AAMP] [Player] [STB] Engine url is not exposed for PPJS
Reason for change: Adding missing playerIDs to the threads for easier debugging Risks: Low Test Procedure: Test with Any AAMP playback Priority: P1 Signed-off-by: nu641001 <[email protected]>
Reason for change: Add playerID for remaining files Risks: Low Priority: P1 Signed-off-by: nu641001 <[email protected]>
VPLAY-9692 [AAMP] Missing player ID with FetcherLoop
Reason for change: Test Patch Test Procedure: Refer Ticket Risks: Low Priority: P1 Signed-off-by: Alsameema <[email protected]>
|
Naren Ramesh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.