Feature/rdk 56050 #224

dp0000 · 2025-07-02T13:02:22Z

pull request upon dev_sprint_25_2

Reason for change: Migration to dev_sprint_25_2 from 117308 (patchset 12) Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

removed .rej

…into feature/RDK-56050

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Signed-off-by: Deepikasri N <[email protected]

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

…K-56050

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Dereference before null check

Null-checking "respData" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
drm/AampDRMLicManager.cpp:1073

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Variable copied when it could be moved

"drmHelper" is passed-by-value as parameter to "std::shared_ptr::shared_ptr(std::shared_ptr const &) /explicit =default/", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""drmHelper"")" instead of "drmHelper".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
drm/AampDRMLicManager.cpp:54

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Use after free

Calling "g_object_get" dereferences freed pointer "this->m_gstElement".

High Impact, CWE-416
USE_AFTER_FREE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/externals/PlayerExternalsInterfaceBase.h:79

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Variable copied when it could be moved

"data" is copied in call to copy assignment for class "std::vector<std::vector<unsigned char, std::allocator >, std::allocator<std::vector<unsigned char, std::allocator > > >", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""data"")" instead of "data".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/drm/DrmSessionManager.cpp:628

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Use after free

Passing freed pointer "this->m_gstElement" as an argument to "logprintf".

High Impact, CWE-416
USE_AFTER_FREE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/externals/PlayerExternalsInterfaceBase.h:82

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Variable copied when it could be moved

"licenseResponse" is passed-by-value as parameter to "std::shared_ptr::shared_ptr(std::shared_ptr const &) /explicit =default/", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""licenseResponse"")" instead of "licenseResponse".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
drm/AampDRMLicManager.cpp:504

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Variable copied when it could be moved

"watermarkSessionUpdateCallback" is passed-by-value as parameter to "std::function<void (unsigned int, unsigned int, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)>::function(std::function<void (unsigned int, unsigned int, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)> const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""watermarkSessionUpdateCallback"")" instead of "watermarkSessionUpdateCallback".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/drm/DrmSessionManager.cpp:60

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Double unlock

"~PlayerScheduler" unlocks "this->mExLock" while it is unlocked.

Medium Impact, CWE-765
LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/externals/playersecmanager/PlayerSecManager.cpp:296

rdkcmf-jenkins · 2025-07-10T10:28:51Z

Coverity Issue - Variable copied when it could be moved

"waterMarkSessionUpdateCB" is passed-by-value as parameter to "std::function<void (unsigned int, unsigned int, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)>::function(std::function<void (unsigned int, unsigned int, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)> const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""waterMarkSessionUpdateCB"")" instead of "waterMarkSessionUpdateCB".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
drm/AampDRMLicManager.cpp:127

Change-Id: I77d0d29b44a01ae8d9fb3ddd455815700a3dbc76

rdkcmf-jenkins · 2025-07-14T06:57:06Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2790

rdkcmf-jenkins · 2025-07-15T07:26:54Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2790

…K-56050

rdkcmf-jenkins · 2025-07-16T04:17:19Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2790

rdkcmf-jenkins · 2025-07-16T04:37:09Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2790

rdkcmf-jenkins · 2025-07-22T10:19:32Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2790

rdkcmf-jenkins · 2025-07-23T09:21:47Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2790

Reason for change: comp issues Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

rdkcmf-jenkins · 2025-07-24T07:47:14Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2790

Vinish100 · 2025-07-24T05:01:13Z

CMakeLists.txt

-	middleware/subtec/libsubtec/SubtecAttribute.hpp
-	middleware/PlayerMetadata.hpp
-)
+set(AAMP_SUBTEC_CLASS_SOURCES subtec/subtecparser/WebvttSubtecDevParser.cpp)


Should we have a follow-up ticket to move these out of AAMP

Yes Vinish, As part of RDK-58626, we will take separation activity too.

Vinish100 · 2025-07-24T05:31:39Z

aampgstplayer.cpp

@@ -411,7 +411,8 @@ AAMPGstPlayer::AAMPGstPlayer(PrivateInstanceAAMP *aamp, id3_callback_t id3Handle
 		}
 		InitializePlayerConfigs(this,playerInstance);
 		playerInstance->SetPlayerName(PLAYER_NAME);
-		playerInstance->setEncryption((void*)aamp);
+                playerInstance->setEncryption((void*)aamp, (void*)aamp->mDRMLicenseManager->mDrmSessionManager);


revisit why aamp is required here.

Vinish100 · 2025-07-24T05:33:41Z

drm/AampDRMLicManager.cpp

 		    return _this->HandleContentProtectionData(drmHelper, streamType, keyId, contentProtectionUpd);
     });
+    /**  Register the profiler update callback for TriggerProfileBeginCb */


As a follow-up, need a single callback with all the profiling data.

Vinish100 · 2025-07-24T05:34:50Z

drm/AampDRMLicManager.cpp

-        aampInstance->mConfig->IsConfigSet(eAAMPConfig_PropagateURIParam),
-        aampInstance->mIsFakeTune
-	);
+        			aampInstance->mConfig->IsConfigSet(eAAMPConfig_UseSecManager),


We should look at the history of why we need all these configs, especially
eAAMPConfig_WideVineKIDWorkaround, eAAMPConfig_PropagateURIParam

Vinish100 · 2025-07-24T05:36:09Z

drm/AampDRMLicManager.cpp

@@ -166,8 +206,8 @@ void AampDRMLicenseManager::renewLicense(std::shared_ptr<DrmHelper> drmHelper, v
 		try
 		{
 			mLicenseRenewalThreads[sessionSlot] = std::thread([this, drmHelper, sessionSlot, aampInstance] {
-        this->licenseRenewalThread(drmHelper, sessionSlot, aampInstance);
-    });
+                                                 this->licenseRenewalThread(drmHelper, sessionSlot, aampInstance);


Fix indentation

Vinish100 · 2025-07-24T08:36:27Z

middleware/externals/contentsecuritymanager/ThunderAccessPlayer.h

@@ -45,6 +45,13 @@ using namespace WPEFramework;

 #define THUNDER_RPC_TIMEOUT 5000

+#define ARRAY_SIZE(A) (sizeof(A)/sizeof(A[0]))


Prefix with MW, as similar macros are present in AAMP

Vinish100 · 2025-07-24T08:37:51Z

middleware/gst-plugins/gst_subtec/gstsubtecsink.cpp

@@ -642,10 +639,10 @@ plugin_init (GstPlugin * plugin)
 #define VERSION "0.1.0"
 #endif
 #ifndef PACKAGE
-#define PACKAGE "AAMPGstreamerPlugins"
+#define PACKAGE "GstreamerPlugins"


RDKGstreamerPlugins or MWGstreamerPlugins

Vinish100 · 2025-07-24T08:38:32Z

middleware/gst-plugins/gstinit.cpp

-		aamp,
-		"Advanced Adaptive Media Player",
+		plugin,
+		"Interface Player",


MW Interface Player?

middleware/scripts/install_libcjson.sh

Vinish100 · 2025-07-24T08:52:49Z

middleware/vendor/amlogic/AmlogicSocInterface.h

@@ -21,7 +21,9 @@
 #define AMLOGIC_SOC_INTERFACE_H

 #include "SocInterface.h"
-
+#if defined(AMLOGIC)
+#include "gst_svp_meta.h"


Why is this required?

removed , can bring svp while during vendor migration

rdkcmf-jenkins · 2025-07-24T12:44:53Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2798

Reason for change: adressing review comments Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

rdkcmf-jenkins · 2025-07-25T11:26:16Z

Coverity Issue - Unchecked return value

Calling "wait_for" without checking return value (as is done elsewhere 13 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
middleware/InterfacePlayerRDK.cpp:2798

Deepikasri1234 and others added 28 commits June 13, 2025 15:32

Delete AampConfig.cpp.rej

c5642e6

removed .rej

Delete aampgstplayer.cpp.rej

4199f1e

Delete CMakeLists.txt.rej

4c37a8f

Merge branch 'feature/RDK-56050' of https://github.com/rdkcentral/aamp …

4441f8b

…into feature/RDK-56050

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

cb69b54

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

d26a213

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

61928c1

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

e997a50

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

4616176

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

Merge remote-tracking branch 'origin/dev_sprint_25_2' into feature/RD…

e25a0fe

…K-56050

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

64462d2

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

6dfc3c4

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

824df3e

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

942ea82

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

Merge branch 'develop' into feature/RDK-56050

79329e4

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

cdb35b8

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

Merge branch 'dev_sprint_25_2' into feature/RDK-56050

2bf2596

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

97b2560

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

7865abf

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

24f6baf

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

e446257

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

85c29bf

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

05b1845

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

Merge branch 'dev_sprint_25_2' into feature/RDK-56050

92b4683

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

e0a088b

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

bf3fd75

Reason for change: for dev_Sprint_25_2 Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

dp0000 requested review from a team as code owners July 2, 2025 13:02

rebase with dev_sprint

867db51

Change-Id: I77d0d29b44a01ae8d9fb3ddd455815700a3dbc76

dev_sprint_25_2 sync

8568564

narenr94 added 2 commits July 16, 2025 09:28

Merge remote-tracking branch 'origin/dev_sprint_25_2' into feature/RD…

bb216ff

…K-56050

build error fix 03

b99e2c8

Resolve L1 build failure for aamp and middleware

dc6f408

Deepikasri1234 added 2 commits July 23, 2025 12:42

Merge branch 'dev_sprint_25_2' into feature/RDK-56050

b6aa02c

resolved compilation issues

dfef122

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

6fdb974

Reason for change: comp issues Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

Vinish100 reviewed Jul 24, 2025

View reviewed changes

Merge branch 'dev_sprint_25_2' into feature/RDK-56050

576ef12

rkandh015 and others added 2 commits July 25, 2025 16:15

removed cjson installation explicitly hence resolved in VPLAY-9947

6ad5fbd

RDK-56050 Merging of OCDM, gst-plugins-rdk into Library - Design

67e8466

Reason for change: adressing review comments Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: If0a31d066478806bae29f09ab829b1108d7856ba Signed-off-by: Deepikasri N <[email protected]

		@@ -45,6 +45,13 @@ using namespace WPEFramework;

		#define THUNDER_RPC_TIMEOUT 5000

		#define ARRAY_SIZE(A) (sizeof(A)/sizeof(A[0]))

Feature/rdk 56050 #224

Are you sure you want to change the base?

Feature/rdk 56050 #224

Conversation

dp0000 commented Jul 2, 2025

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Dereference before null check

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Use after free

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Use after free

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Double unlock

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 10, 2025

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 14, 2025

Coverity Issue - Unchecked return value

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 15, 2025

Coverity Issue - Unchecked return value

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 16, 2025

Coverity Issue - Unchecked return value

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 16, 2025

Coverity Issue - Unchecked return value

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 22, 2025

Coverity Issue - Unchecked return value

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 23, 2025

Coverity Issue - Unchecked return value

Issue location

Uh oh!

rdkcmf-jenkins commented Jul 24, 2025

Coverity Issue - Unchecked return value

Issue location

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment