VPLAY-9810:Add droppedFrames to MonitorAV event #270
Conversation
| std::string sid): | ||
| AAMPEventObject(AAMP_EVENT_PROGRESS, std::move(sid)), mDuration(duration), | ||
| mPosition(position), mStart(start), | ||
| mEnd(end), mSpeed(speed), mPTS(pts), | ||
| mBufferedDuration(bufferedDuration), | ||
| mVideoBufferedDurationMs(videoBufferedDuration), | ||
| mAudioBufferedDurationMs(audioBufferedDuration), | ||
| mSEITimecode(seiTimecode), |
There was a problem hiding this comment.
Coverity Issue - Variable copied when it could be moved
"seiTimecode" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""seiTimecode"")" instead of "seiTimecode".
varshnie
force-pushed
the
feature/VPLAY-9810
branch
from
35aa67d to
5529e22
Compare
varshnie
force-pushed
the
feature/VPLAY-9810
branch
from
5529e22 to
855077f
Compare
Reason for change:Added audio buffered duration as a part of mediaprogress event and dropped frames as part of monitorav event Risks: Low Test Procedure: Refer jira ticket Priority: P2 Signed-off-by: varshnie [email protected]
varshnie
force-pushed
the
feature/VPLAY-9810
branch
from
855077f to
c444cd3
Compare
Reason for change:Added audio buffered duration as a part of mediaprogress event and dropped frames as part of monitorav event Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: varshnie [email protected]
varshnie
force-pushed
the
feature/VPLAY-9810
branch
from
732ba02 to
5d5be90
Compare
Coverity Issue - Unchecked return valueCalling "GetCurrentTextTrack" without checking return value (as is done elsewhere 1 out of 1 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "GetCurrentAudioTrack" without checking return value (as is done elsewhere 2 out of 2 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionAccessing "this->numberOfFragmentChunksCached" without holding lock "MediaTrack.mutex". Elsewhere, "MediaTrack.numberOfFragmentChunksCached" is written to with "MediaTrack.mutex" held 3 out of 3 times (2 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"processor" is copied in call to copy assignment for class "std::shared_ptr", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""processor"")" instead of "processor". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Reason for change:Added audio buffered duration as a part of mediaprogress event and dropped frames as part of monitorav event Risks: Low
Test Procedure: Refer jira ticket
Priority: P2
Signed-off-by: varshnie [email protected]