Skip to content

Feature/vplay 9633 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev_sprint_25_2
Choose a base branch
from
Open

Conversation

hthakkar-synamedia
Copy link
Contributor

Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position
A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush.
Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush
Refactors the code by introducing ReinitializeInjection API
Test Procedure: Refer to the Ticket.
Risks: Low

hthakkar-synamedia and others added 3 commits July 16, 2025 16:05
…ition

Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position
                     A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush.

Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush
Refactors the code by introducing ReinitializeInjection API

Test Procedure: Refer to the Ticket.

Risks: Low
…ition

Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position
                     A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush.

Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush
Refactors the code by introducing ReinitializeInjection API

Test Procedure: Refer to the Ticket.

Risks: Low
@CLAassistant
Copy link

CLAassistant commented Jul 16, 2025

CLA assistant check
All committers have signed the CLA.

@rdkcmf-jenkins
Copy link

Coverity Issue - Variable copied when it could be moved

"processor" is copied in call to copy assignment for class "std::shared_ptr", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""processor"")" instead of "processor".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
streamabstraction.cpp:4033

…ition

Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position
                     A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush.

Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush
Refactors the code by introducing ReinitializeInjection API

Test Procedure: Refer to the Ticket.

Risks: Low
Signed-off-by: hthakkar-synamedia <[email protected]>
@rdkcmf-jenkins
Copy link

Coverity Issue - Data race condition

Accessing "this->numberOfFragmentChunksCached" without holding lock "MediaTrack.mutex". Elsewhere, "MediaTrack.numberOfFragmentChunksCached" is written to with "MediaTrack.mutex" held 3 out of 3 times (2 of these accesses strongly imply that it is necessary).

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
streamabstraction.cpp:1839

@rdkcmf-jenkins
Copy link

Coverity Issue - Unchecked return value

Calling "GetCurrentTextTrack" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
priv_aamp.cpp:10174

@rdkcmf-jenkins
Copy link

Coverity Issue - Wait without held lock

"FetchFragment" waits while "pMediaStreamContext->mutex" is unlocked.

Medium Impact, CWE-667
LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
fragmentcollector_mpd.cpp:5481

@rdkcmf-jenkins
Copy link

Coverity Issue - Double unlock

"PushNextFragment" unlocks "pMediaStreamContext->mutex" while it is unlocked.

Medium Impact, CWE-765
LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
fragmentcollector_mpd.cpp:9044

@rdkcmf-jenkins
Copy link

Coverity Issue - Unchecked return value

Calling "GetCurrentAudioTrack" without checking return value (as is done elsewhere 2 out of 2 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
priv_aamp.cpp:10054

@rdkcmf-jenkins
Copy link

Coverity Issue - Data race condition

Accessing "pMediaStreamContext->numberOfFragmentChunksCached" without holding lock "MediaTrack.mutex". Elsewhere, "MediaTrack.numberOfFragmentChunksCached" is written to with "MediaTrack.mutex" held 3 out of 3 times (2 of these accesses strongly imply that it is necessary).

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
fragmentcollector_mpd.cpp:9103

@hthakkar-synamedia hthakkar-synamedia marked this pull request as ready for review July 21, 2025 11:35
@hthakkar-synamedia hthakkar-synamedia requested review from a team as code owners July 21, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants