-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/vplay 9633 #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev_sprint_25_2
Are you sure you want to change the base?
Feature/vplay 9633 #282
Conversation
…ition Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush. Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush Refactors the code by introducing ReinitializeInjection API Test Procedure: Refer to the Ticket. Risks: Low
…ition Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush. Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush Refactors the code by introducing ReinitializeInjection API Test Procedure: Refer to the Ticket. Risks: Low
Coverity Issue - Variable copied when it could be moved"processor" is copied in call to copy assignment for class "std::shared_ptr", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""processor"")" instead of "processor". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
…ition Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush. Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush Refactors the code by introducing ReinitializeInjection API Test Procedure: Refer to the Ticket. Risks: Low Signed-off-by: hthakkar-synamedia <[email protected]>
Coverity Issue - Data race conditionAccessing "this->numberOfFragmentChunksCached" without holding lock "MediaTrack.mutex". Elsewhere, "MediaTrack.numberOfFragmentChunksCached" is written to with "MediaTrack.mutex" held 3 out of 3 times (2 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "GetCurrentTextTrack" without checking return value (as is done elsewhere 1 out of 1 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Wait without held lock"FetchFragment" waits while "pMediaStreamContext->mutex" is unlocked. Medium Impact, CWE-667 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Double unlock"PushNextFragment" unlocks "pMediaStreamContext->mutex" while it is unlocked. Medium Impact, CWE-765 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "GetCurrentAudioTrack" without checking return value (as is done elsewhere 2 out of 2 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionAccessing "pMediaStreamContext->numberOfFragmentChunksCached" without holding lock "MediaTrack.mutex". Elsewhere, "MediaTrack.numberOfFragmentChunksCached" is written to with "MediaTrack.mutex" held 3 out of 3 times (2 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Reason for Change: - Changing the audio track for LLD causes the position to jump to live edge instead of live play position
A bug was discovered in Tunehelper that caused a wrong pts value sent during the flush.
Changes: Clears the mFirstPTS value to trigger the update of the first PTS value sent during the flush
Refactors the code by introducing ReinitializeInjection API
Test Procedure: Refer to the Ticket.
Risks: Low