VPLAY-10090 VPLAY-10399 - Audio loss in Trick to play transition in L2 tests #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity Issue - Data race conditionAccessing "pMediaStreamContext->numberOfFragmentChunksCached" without holding lock "MediaTrack.mutex". Elsewhere, "MediaTrack.numberOfFragmentChunksCached" is written to with "MediaTrack.mutex" held 3 out of 3 times (2 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "GetCurrentTextTrack" without checking return value (as is done elsewhere 1 out of 1 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Double unlock"PushNextFragment" unlocks "pMediaStreamContext->mutex" while it is unlocked. Medium Impact, CWE-765 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "GetCurrentAudioTrack" without checking return value (as is done elsewhere 2 out of 2 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
dnfaulkner
reviewed
Jul 18, 2025
anjali-syna
force-pushed
the
feature/VPLAY-10090
branch
2 times, most recently
from
1b3f4d4 to
12b124c
Compare
Vinish100
reviewed
Jul 25, 2025
shripadbpersonal
changed the title
…ests Reason for change: Audio is lost while performing fast forward to live in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pipeline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Run L2 tests Risks: Low
…ests Reason for change: Audio is lost while performing live pause and fast forward to live using LLD test asset in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pileline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Run L2 tests Risks: Low Signed-off-by: anjali-syna <[email protected]>
…ests Reason for change: Audio is lost while performing fast forward to live in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pipeline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Refer JIRA ticket Risks: Low Signed-off-by: anjali-syna <[email protected]>
…ests Reason for change: Audio is lost while performing fast forward to live in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pipeline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Refer JIRA ticket Risks: Low Signed-off-by: anjali-syna <[email protected]>
Vinish100
force-pushed
the
feature/VPLAY-10090
branch
from
784f8b4 to
aac79d7
Compare
Vinish100
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Audio is lost while performing live pause and fast forward to live using LLD test asset in L2 test environment.
Changes: Perform Flush after Configure in TuneHelper. Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided.
Test Procedure: Refer Jira Ticket