-
Notifications
You must be signed in to change notification settings - Fork 5
VPLAY-10090 VPLAY-10399 - Audio loss in Trick to play transition in L2 tests #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverity Issue - Data race conditionAccessing "pMediaStreamContext->numberOfFragmentChunksCached" without holding lock "MediaTrack.mutex". Elsewhere, "MediaTrack.numberOfFragmentChunksCached" is written to with "MediaTrack.mutex" held 3 out of 3 times (2 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "GetCurrentTextTrack" without checking return value (as is done elsewhere 1 out of 1 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Double unlock"PushNextFragment" unlocks "pMediaStreamContext->mutex" while it is unlocked. Medium Impact, CWE-765 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "GetCurrentAudioTrack" without checking return value (as is done elsewhere 2 out of 2 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment
1b3f4d4
to
12b124c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…ests Reason for change: Audio is lost while performing fast forward to live in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pipeline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Run L2 tests Risks: Low
…ests Reason for change: Audio is lost while performing live pause and fast forward to live using LLD test asset in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pileline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Run L2 tests Risks: Low Signed-off-by: anjali-syna <[email protected]>
…ests Reason for change: Audio is lost while performing fast forward to live in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pipeline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Refer JIRA ticket Risks: Low Signed-off-by: anjali-syna <[email protected]>
…ests Reason for change: Audio is lost while performing fast forward to live in L2 test environment. This is because in TuneHelper, Configure is happening after Flush() call with proper seek position. This results in pipeline loosing the flush and seek, thus affecting AV sync. Changes: * Perform Flush after Configure in TuneHelper * Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided. * Adding new unit test:TuneHelperWithAampTsbConfigureFlushSequence Test Procedure: Refer JIRA ticket Risks: Low Signed-off-by: anjali-syna <[email protected]>
784f8b4
to
aac79d7
Compare
Reason for change: Audio is lost while performing live pause and fast forward to live using LLD test asset in L2 test environment.
Changes: Perform Flush after Configure in TuneHelper. Also, call flush with shouldTearDown false, because in case of a new tune, pipeline might not be in a playing/paused state which causes Flush() to destroy the pipeline. This has to be avoided.
Test Procedure: Refer Jira Ticket