Skip to content

fix: Issue 374 notice-wrapper::after Style in stack-expanded #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

ilya-vol
Copy link
Contributor

@ilya-vol ilya-vol commented Jun 30, 2025

fix the pseudo-element of notice-wrapper cover issue, change pseudo-element after to before.

close #374

Summary by CodeRabbit

  • 新功能

    • 堆叠通知示例现在支持关闭按钮,用户可手动关闭通知。
  • 样式

    • 优化通知堆叠样式,调整伪元素的位置但不影响视觉效果。

Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 4:59pm

Copy link

coderabbitai bot commented Jun 30, 2025

Walkthrough

本次更新主要包括两个方面:一是在样式文件中将伪元素选择器由 ::after 改为 ::before,二是在通知组件的示例代码中为通知项增加了可关闭(closable)选项。

Changes

文件/分组 变更摘要
assets/index.less .rc-notification-stack-expanded > .rc-notification-notice-wrapper 的伪元素选择器从 ::after 改为 ::before,样式内容未变。
docs/examples/stack.tsx useNotification 配置中新增 closable: true,使通知支持关闭功能。

Poem

小兔挥笔更样式,
伪元素悄悄换了位。
通知弹窗加按钮,
轻点即可消消息。
代码世界新气象,
跳跃前行乐无穷!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

docs/examples/stack.tsx

Oops! Something went wrong! :(

ESLint: 7.32.0

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react@latest --save-dev

The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs[email protected]/node_modules/@umijs/fabric/dist/eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de13217 and ea1dd93.

📒 Files selected for processing (2)
  • assets/index.less (1 hunks)
  • docs/examples/stack.tsx (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
docs/examples/stack.tsx (1)
src/hooks/useNotification.tsx (1)
  • useNotification (76-187)
🔇 Additional comments (2)
assets/index.less (1)

242-253: 修复合理:伪元素选择器调整解决了交互阻塞问题

将伪元素选择器从 ::after 改为 ::before 是一个明智的修复。::after 会出现在内容上方,可能会阻塞关闭按钮等UI元素的点击交互,而 ::before 出现在内容后方,既保持了扩展的点击区域(pointer-events: auto),又不会干扰实际的界面元素交互。

这个修改与在示例中添加 closable: true 选项形成了很好的配合,确保关闭按钮能够正常工作。

docs/examples/stack.tsx (1)

18-18: 配置更新恰当:启用关闭功能展示样式修复效果

添加 closable: true 选项能够为堆叠通知启用关闭功能,这与 CSS 文件中伪元素选择器的修复形成了完美配合。此配置变更不仅改进了用户体验,还有效展示了 ::before 伪元素修复的实际效果 - 确保关闭按钮不会被伪元素遮挡而无法点击。

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@afc163 afc163 merged commit 53d2483 into react-component:master Jul 1, 2025
7 checks passed
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (de13217) to head (ea1dd93).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           7        7           
  Lines         772      772           
  Branches      124      124           
=======================================
  Hits          770      770           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the notice-wrapper::after Style in stack-expanded
2 participants