Skip to content

Upgrade all the packages with ncu #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 3, 2025

Closes #580
Closes #572
Requires #593

humitos added 2 commits June 3, 2025 13:59
`fixture` expects the element to have a specific method:

https://open-wc.org/docs/testing/helpers/#timings

Since a regular `div` doesn't have that method, it fails.

I found this while upgrading the packages using `ncu`. It seems that newer
versions are more strict -- which makes sense. Related #580
@humitos humitos requested a review from a team as a code owner June 3, 2025 12:03
@humitos humitos requested a review from agjohnson June 3, 2025 12:03
Base automatically changed from humitos/ethicalad-tests to main June 4, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant