Skip to content

Publish canceled subscriptions into #rtd-notifications channel #12228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 3, 2025

No description provided.

@humitos humitos requested a review from a team as a code owner June 3, 2025 13:12
@humitos humitos requested a review from stsewd June 3, 2025 13:12
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just renaming a setting?

@humitos
Copy link
Member Author

humitos commented Jun 4, 2025

Yeah, sorry. This shouldn't be assigned to you for review. I pinged @ericholscher on Slack for this.

@humitos humitos requested a review from ericholscher June 4, 2025 10:01
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just have a setting for the notification, not the channel? Like SLACK_CANCELLATION_CHANNEL? Seems odd to specify the actual channel name, since it leads to weird PRs like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants