Let the sensitive parts of credentials to be defined externally as variables #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonisgarciac
requested changes
May 27, 2025
Tompage1994
requested changes
May 27, 2025
Tompage1994
reviewed
May 27, 2025
|
This is a new feature. I don't see what to specify into a changelog: https://docs.ansible.com/ansible-core/devel/dev_guide/testing/sanity/changelog.html |
ivarmu
force-pushed
the
variables_for_sensitive_data
branch
from
aa919fa to
6e1761e
Compare
|
I would probably make it a minor change |
Tompage1994
approved these changes
Jun 10, 2025
ivarmu
force-pushed
the
variables_for_sensitive_data
branch
from
e2372c3 to
cca8575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Let's the credentials and users (having sentitive data not exported by default) be used directly thanks to export the sensitiva data to external variables with a given syntax (see README.md for more details).
How should this be tested?
Manullay tested
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
N/A