chore: Cleanup go.mod #931
Conversation
|
|
||
| sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.19.1 | ||
| ) | ||
| replace k8s.io/client-go => k8s.io/client-go v0.33.0 |
There was a problem hiding this comment.
Managed to remove most of the replace statements 🕺. However, one of the dependencies still expects client-go at version v0.12.0, which doesn't exist. So we need to explicitly add a replace directive to use the latest version instead.
|
/retest |
|
/retest Failure is likely this (race condition in product, not a test bug) #909 |
|
/lgtm |
|
@svghadi: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varshab1210 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
svghadi
force-pushed
the
update-argocd-operator
branch
from
106a7f1 to
366fb85
Compare
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
force-pushed
the
update-argocd-operator
branch
from
bd33d91 to
91a1262
Compare
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
changed the title
What type of PR is this?
/kind chore
What does this PR do / why we need it:
This PR cleans up go.mod by removing replaces block.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: