Skip to content

Conversation

olivergondza
Copy link

@olivergondza olivergondza commented Aug 11, 2025

What type of PR is this?

/kind cleanup

What does this PR do / why we need it:

The goal was duplicate with similar (but not same) logic - eliminated.

The implementation was silently picking operator-sdk when on PATH - must be provided through OPERATOR_SDK now. Element of least astonishment.

Conditional Makefile logic removed leveraging native make features.

Have you updated the necessary documentation?

  • [n/a] Documentation update is required by this PR.
  • [n/a] Documentation has been updated.

Which issue(s) this PR fixes:

None

Test acceptance criteria:

  • [n/a] Unit Test
  • [n/a] E2E Test

How to test changes / Special notes to the reviewer:

  • make bundle
  • rm -rf ./bin && make bundle
  • make OPERATOR_SDK=/bin/operator-sdk bundle # When installed locally

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process. label Aug 11, 2025
Copy link

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign varshab1210 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 11, 2025

Hi @olivergondza. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

OPERATOR_SDK = $(shell which operator-sdk)
endif
endif
operator-sdk: $(OPERATOR_SDK)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goal deps are satisfied when user provided existing installation through OPERATOR_SDK, or when they did not but the file exists. When neither is the case bin/operator-sdk goal kicks in.

@olivergondza olivergondza force-pushed the makefile-operator-sdk-refactor branch from 65b14c6 to 236ce0c Compare August 11, 2025 09:07
The goal was duplicate with similar (but not same) logic - eliminated.

The implementation was silently picking operator-sdk when on PATH - must be provided through OPERATOR_SDK now.
Element of least astonishment.

Conditional Makefile logic removed leveraging native make features.

Signed-off-by: Oliver Gondža <[email protected]>
@olivergondza olivergondza force-pushed the makefile-operator-sdk-refactor branch from 236ce0c to 414852f Compare August 11, 2025 09:10
@jgwest
Copy link
Collaborator

jgwest commented Aug 11, 2025

/ok-to-test

@olivergondza
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants