-
Notifications
You must be signed in to change notification settings - Fork 337
fix(Makefile): Remove duplicate operator-sdk goal, simplify code #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(Makefile): Remove duplicate operator-sdk goal, simplify code #944
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @olivergondza. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OPERATOR_SDK = $(shell which operator-sdk) | ||
endif | ||
endif | ||
operator-sdk: $(OPERATOR_SDK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goal deps are satisfied when user provided existing installation through OPERATOR_SDK
, or when they did not but the file exists. When neither is the case bin/operator-sdk
goal kicks in.
65b14c6
to
236ce0c
Compare
The goal was duplicate with similar (but not same) logic - eliminated. The implementation was silently picking operator-sdk when on PATH - must be provided through OPERATOR_SDK now. Element of least astonishment. Conditional Makefile logic removed leveraging native make features. Signed-off-by: Oliver Gondža <[email protected]>
236ce0c
to
414852f
Compare
/ok-to-test |
/retest |
What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
The goal was duplicate with similar (but not same) logic - eliminated.
The implementation was silently picking operator-sdk when on PATH - must be provided through OPERATOR_SDK now. Element of least astonishment.
Conditional Makefile logic removed leveraging native make features.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
None
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
make bundle
rm -rf ./bin && make bundle
make OPERATOR_SDK=/bin/operator-sdk bundle
# When installed locally