Skip to content

DEV: FP32 (vectorsets) should explicitly document endianness #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Aug 12, 2025

Fixes #1967.
Fixes #1972.

Also includes updates to the return information for the VLINKS command page.

Tests used to confirm the correct return information for the VLINKS command:

RESP2

vlinks vs element1
*1
*2
$8
element2
$8
element3
vlinks vs element1 withscores
*1
*4
$8
element2
$17
0.996941864490509
$8
element3
$3
0.5
vlinks foo
-ERR wrong number of arguments for 'VLINKS' command
vlinks vs foo
$-1
vlinks foo bar
$-1

RESP3

vlinks vs element1
*1
*2
$8
element2
$8
element3
vlinks vs element1 withscores
*1
%2
$8
element2
,0.996941864490509
$8
element3
,0.5
vlinks foo
-ERR wrong number of arguments for 'VLINKS' command
vlinks vs foo
_
vlinks foo bar
_

@dwdougherty dwdougherty requested a review from a team August 12, 2025 16:49
@dwdougherty dwdougherty self-assigned this Aug 12, 2025
Copy link
Contributor

github-actions bot commented Aug 12, 2025

DOC-5572

@dwdougherty
Copy link
Collaborator Author

Thank you, @cmilesb!

@dwdougherty dwdougherty merged commit dfd1566 into main Aug 12, 2025
6 checks passed
@dwdougherty dwdougherty deleted the DOC-5572 branch August 12, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback: VLINKS return information is incomplete / incorrect Feedback: FP32 (vectorsets) should explicitly document endianness
2 participants