Added support for Pub/Sub mode in MultiDbClient #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into vv-pubsub-support
… into vv-pubsub-support
… into vv-pubsub-support
petyaslavova
reviewed
Aug 7, 2025
| ) -> "PubSubWorkerThread": | ||
| def callback(): | ||
| return self._active_pubsub.run_in_thread( | ||
| sleep_time, daemon=daemon, exception_handler=exception_handler, pubsub=pubsub |
There was a problem hiding this comment.
Why do we need to provide the pubsub reference here? If a failover has occurred, shouldn’t _active_pubsub already contain all the necessary information? By passing in this reference, don’t we risk holding onto a pubsub object from a failed instance and potentially trying to work with it?
| r_multi_db.spublish('test-channel', data) | ||
| sleep(0.1) | ||
|
|
There was a problem hiding this comment.
What do we expect to have happened in the pubsub_thread? Would it be worth validating whether it completed successfully or failed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.