Skip to content

Make element returned by useOutlet have stable-ish reference #13382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Make element returned by useOutlet have stable-ish reference #13382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b67d239
Made element returned by useOutlet have stable reference
Malien Apr 7, 2025
9932b01
Add Malien to contributors.yml
Malien Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
- m-shojaei
- machour
- majamarijan
- Malien
- Manc
- manzano78
- marc2332
Expand Down
15 changes: 9 additions & 6 deletions packages/react-router/lib/hooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,15 @@ export function useOutletContext<Context = unknown>(): Context {
*/
export function useOutlet(context?: unknown): React.ReactElement | null {
let outlet = React.useContext(RouteContext).outlet;
if (outlet) {
return (
<OutletContext.Provider value={context}>{outlet}</OutletContext.Provider>
);
}
return outlet;
return React.useMemo(
() =>
outlet && (
<OutletContext.Provider value={context}>
{outlet}
</OutletContext.Provider>
),
[outlet, context]
);
}

/**
Expand Down