-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
fix(dev/config): fix package.json
resolution with custom server.entry
#13744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @markmals, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
package.json
resolution with custom server.entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your branch onto latest dev
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@MichaelDeBoey done! Let me know if there's anything else I need to do. I couldn't figure out how to make this PR target dev instead of main in the GitHub UI |
Skip
package.json
file checks when a user-supplied entry.server file is present