Skip to content

fix: use workspace relative url when uploading artifacts #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented May 30, 2025

Description

  • merge_reports is failing when ui_tests is executed from external repository as no artifacts are uploaded for it to merge
  • Artifacts were not being uploaded because the action looks for a local relative path that does not exist in external repository

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

changeset-bot bot commented May 30, 2025

⚠️ No Changeset found

Latest commit: b8c1990

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ❌ Failed (Inspect) May 30, 2025 0:43am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 0:43am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 0:43am
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) May 30, 2025 0:43am
appkit-basic-example ⬜️ Ignored (Inspect) May 30, 2025 0:43am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) May 30, 2025 0:43am
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview May 30, 2025 0:43am
appkit-ethers5-bera ⬜️ Ignored (Inspect) May 30, 2025 0:43am
appkit-nansen-demo ⬜️ Ignored (Inspect) May 30, 2025 0:43am
appkit-vue-solana ⬜️ Ignored (Inspect) May 30, 2025 0:43am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) May 30, 2025 0:43am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) May 30, 2025 0:43am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) May 30, 2025 0:43am
vue-wagmi-example ⬜️ Ignored (Inspect) May 30, 2025 0:43am

Copy link
Contributor

Warnings
⚠️

Workflow file .github/workflows/ui_tests.yml has been modified

⚠️

File .github/workflows/ui_tests.yml contains a KEY or SECRET

Generated by 🚫 dangerJS against b8c1990

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 76.52% 27426 / 35838
🔵 Statements 76.52% 27426 / 35838
🔵 Functions 68.16% 2317 / 3399
🔵 Branches 83.75% 5526 / 6598
File CoverageNo changed files found.
Generated in workflow #12308 for commit b8c1990 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants