-
Notifications
You must be signed in to change notification settings - Fork 6
K0s 1.30 - DO NOT MERGE #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K0s 1.30 - DO NOT MERGE #2182
Changes from all commits
4189341
d0e2a7a
34a8c47
ba74652
3f9d4dc
10fdd74
3297172
91cf229
9e34282
347bd8f
cca363a
00fec0c
24eb456
01c8dbc
86fc2c0
3749629
3144102
50f2e2f
a3da8fd
89f7777
abc058a
5b95c0e
c38e17e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,10 +111,6 @@ | |
"items": { | ||
"description": "Repository describes single repository entry. Fields map to the CLI flags for the \"helm add\" command", | ||
"type": "object", | ||
"required": [ | ||
"name", | ||
"url" | ||
], | ||
"properties": { | ||
"caFile": { | ||
"description": "CA bundle file to use when verifying HTTPS-enabled servers.", | ||
|
@@ -134,17 +130,15 @@ | |
}, | ||
"name": { | ||
"description": "The repository name.", | ||
"type": "string", | ||
"minLength": 1 | ||
"type": "string" | ||
}, | ||
"password": { | ||
"description": "Password for Basic HTTP authentication.", | ||
"type": "string" | ||
}, | ||
"url": { | ||
"description": "The repository URL.", | ||
"type": "string", | ||
"minLength": 1 | ||
"type": "string" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Helm Repo Validation Constraints RemovedCritical validation constraints for Helm repository configurations were removed. The Locations (5)
|
||
}, | ||
"username": { | ||
"description": "Username for Basic HTTP authentication.", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Helm Repository Validation Bypass
Removing
required
andminLength: 1
validation for Helm repositoryname
andurl
fields allows empty or missing values. This will lead to runtime failures when the system attempts to use or add these repositories.Additional Locations (3)
operator/config/crd/bases/embeddedcluster.replicated.com_configs.yaml#L110-L123
operator/config/crd/bases/embeddedcluster.replicated.com_installations.yaml#L176-L190
operator/config/crd/bases/embeddedcluster.replicated.com_kubernetesinstallations.yaml#L129-L147