add vim mode setting to playground #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbertramResi is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
rbertramResi
force-pushed
the
add-vim-mode
branch
from
8d7cf1b to
1c7c4de
Compare
rbertramResi
force-pushed
the
add-vim-mode
branch
from
1c7c4de to
4586f71
Compare
fhammerschmidt
requested changes
Jul 25, 2025
src/Playground.res
Outdated
| let (keyMap, setKeyMap) = React.useState(() => { | ||
| Dom.Storage2.localStorage | ||
| ->Dom.Storage2.getItem("vimMode") | ||
| ->Belt.Option.map(CodeMirror.KeyMap.fromString) |
There was a problem hiding this comment.
just use Option without the Belt
There was a problem hiding this comment.
updated 👍 And changed the label over the toggle to "Use Vim Keymap"
rbertramResi
force-pushed
the
add-vim-mode
branch
from
71f0f5d to
3abae75
Compare
fhammerschmidt
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.