Skip to content

Fix Windows CI #7665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Fix Windows CI #7665

merged 1 commit into from
Jul 19, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 18, 2025

On Windows, after running setup-ocaml (if it wasn't cached yet or the cache couldn't be restored), Cygwin bash is used instead of Git Bash for Windows, breaking the rewatch tests.

So we need to adjust the path to bring back Git Bash for Windows.

@nojaf
Copy link
Collaborator

nojaf commented Jul 18, 2025

Would we also benefit from https://discuss.ocaml.org/t/ann-opam-2-4-0-is-out/16989 ?

Copy link

pkg-pr-new bot commented Jul 18, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7665

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7665

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7665

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7665

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7665

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7665

commit: 8683898

@cknitt cknitt force-pushed the windows-ci branch 6 times, most recently from 5b9ab27 to 10055c2 Compare July 19, 2025 05:17
@cknitt
Copy link
Member Author

cknitt commented Jul 19, 2025

Would we also benefit from https://discuss.ocaml.org/t/ann-opam-2-4-0-is-out/16989 ?

Don't know if it brings any benefits for us, but it will become available once ocaml/setup-ocaml#970 is merged.

@cknitt cknitt changed the title setup-ocaml 3.3.5 Fix Windows CI Jul 19, 2025
@cknitt cknitt requested a review from nojaf July 19, 2025 05:53
@cknitt cknitt merged commit 9f65d3d into master Jul 19, 2025
27 checks passed
@cknitt cknitt deleted the windows-ci branch July 19, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants